linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <dwg@au1.ibm.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [patch 04/10] 4xx bootwrapper reworks
Date: Tue, 7 Aug 2007 13:05:47 +1000	[thread overview]
Message-ID: <20070807030547.GC15619@localhost.localdomain> (raw)
In-Reply-To: <20070806123602.GZ3925@crusty.rchland.ibm.com>

On Mon, Aug 06, 2007 at 07:36:03AM -0500, Josh Boyer wrote:
> On Mon, Aug 06, 2007 at 02:38:55PM +1000, David Gibson wrote:
> > On Fri, Aug 03, 2007 at 11:09:04AM -0500, Josh Boyer wrote:
> > > -#define SPRN_DBCR0		0x134
> > > -#define   DBCR0_RST_SYSTEM	0x30000000
> > > +#define DBCR0_RST_SYSTEM 0x30000000
> > 
> > Rather than just removing these defines and using hardcoded values,
> > I'd prefer to see separate SPRN_DBCR0_40X and SPRN_DBCR0_44X defines.
> 
> Ok.  And place them where?  In the same file since they aren't DCR defines?
> Seems fairly trivial, but ok.

Just where the old 44x specific define was. And yes, it is fairly
trivial.

> > [snip]
> > > +#define EMAC_RESET 0x20000000
> > > +#define MAL_RESET 0x80000000
> > 
> > I think the MAL_RESET definition should go in the same place as the
> > DCR number definition.
> 
> Ok.  Trivial.

Yes.

> > As I think I said before, I'm not really happy with this being
> > hardcoded assuming exactly 2 ethernets.
> 
> Well, it's hardcoded to assume one or two.  I know of only one board that has
> more than two EMACs.  I was hoping we could get this in for 2.6.24 as-is and
> change it when needs be.  But I'll look at making it var-args or similar.
> 
> josh
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2007-08-07  3:51 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-03 16:09 [patch 00/10] 4xx patch series for 2.6.24 Josh Boyer
2007-08-03 16:09 ` [patch 01/10] Rename 4xx paths to 40x Josh Boyer
2007-08-03 16:09 ` [patch 02/10] 4xx Kconfig cleanup Josh Boyer
2007-08-04  7:45   ` David Gibson
2007-08-06 12:31     ` Josh Boyer
2007-08-07  3:06       ` David Gibson
2007-08-03 16:09 ` [patch 03/10] Rename 44x bootwrapper Josh Boyer
2007-08-06  4:36   ` David Gibson
2007-08-03 16:09 ` [patch 04/10] 4xx bootwrapper reworks Josh Boyer
2007-08-06  4:38   ` David Gibson
2007-08-06 12:36     ` Josh Boyer
2007-08-07  3:05       ` David Gibson [this message]
2007-08-07 13:10         ` Josh Boyer
2007-08-08  1:19           ` David Gibson
2007-08-03 16:09 ` [patch 05/10] 40x MMU Josh Boyer
2007-08-06  4:34   ` David Gibson
2007-08-03 16:09 ` [patch 06/10] 40x decrementer fixes Josh Boyer
2007-08-03 16:47   ` Sergei Shtylyov
2007-08-03 17:10     ` Sergei Shtylyov
2007-08-03 17:25       ` Josh Boyer
2007-08-03 17:30         ` Sergei Shtylyov
2007-08-03 17:30           ` Josh Boyer
2007-08-03 17:35             ` Sergei Shtylyov
2007-08-04  2:28       ` Benjamin Herrenschmidt
2007-08-05 14:12         ` Sergei Shtylyov
2007-08-03 17:15     ` Josh Boyer
2007-08-03 17:25       ` Sergei Shtylyov
2007-08-04  2:28     ` Benjamin Herrenschmidt
2007-08-05 14:19       ` Sergei Shtylyov
2007-08-03 16:09 ` [patch 07/10] Fix 40x build Josh Boyer
2007-08-06  4:39   ` David Gibson
2007-08-03 16:09 ` [patch 08/10] Bamboo DTS Josh Boyer
2007-08-06  4:53   ` David Gibson
2007-08-06 18:01     ` Jon Loeliger
2007-08-06 18:05       ` Josh Boyer
2007-08-07 13:11     ` Josh Boyer
2007-08-03 16:09 ` [patch 09/10] Bamboo board support Josh Boyer
2007-08-06  4:55   ` David Gibson
2007-08-03 16:09 ` [patch 10/10] Bamboo zImage wrapper Josh Boyer
2007-08-06  5:00   ` David Gibson
2007-08-06 12:39     ` Josh Boyer
2007-08-07  3:04       ` David Gibson
2007-08-07  3:04   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070807030547.GC15619@localhost.localdomain \
    --to=dwg@au1.ibm.com \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).