linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Josh Boyer <jwboyer@linux.vnet.ibm.com>,
	Jon Loeliger <jdl@freescale.com>,
	linuxppc-dev@ozlabs.org
Subject: Device tree aware EMAC driver
Date: Tue, 7 Aug 2007 16:22:31 +1000	[thread overview]
Message-ID: <20070807062231.GB8351@localhost.localdomain> (raw)

Based on BenH's earlier work, this is a new version of the EMAC driver
for the built-in ethernet found on PowerPC 4xx embedded CPUs.  The
same ASIC is also found in the Axon bridge chip.  This new version is
designed to work in the arch/powerpc tree, using the device tree to
probe the device, rather than the old and ugly arch/ppc OCP layer.

This driver is designed to sit alongside the old driver (it lies in
drivers/net/ibm_emac and this one in drivers/net/ibm_newemac).  The
old driver is left in place to support arch/ppc until arch/ppc itself
reaches its final demise (not too long now, with luck).

This driver still has a number of things that could do with cleaning
up, but I think they can be fixed up after merging.  Specifically:
	- Should be adjusted to properly use the dma mapping API.
Axon needs this.
	- Probe logic needs reworking, in conjuction with the general
probing code for of_platform devices.  The dependencies here between
EMAC, MAL, ZMII etc. make this complicated.  At present, it usually
works, because we initialize and register the sub-drivers before the
EMAC driver itself, and (being in driver code) runs after the devices
themselves have been instantiated from the device tree.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---

Paul, I discussed with BenH, and although there are some problems with
the driver still, we think it's good enough to merge in 2.6.24, the
warts can be fixed up later.

Too big for the list, patch is at:
	http://ozlabs.org/~dgibson/home/emac/powerpc-emac-new-20070807.patch

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

             reply	other threads:[~2007-08-07  6:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-07  6:22 David Gibson [this message]
2007-08-07 12:15 ` Device tree aware EMAC driver Josh Boyer
2007-08-08  1:18   ` David Gibson
2007-08-08  3:16 ` Tony Breeds
2007-08-08  5:09   ` David Gibson
2007-08-08  7:34     ` Benjamin Herrenschmidt
2007-08-08  7:33   ` Benjamin Herrenschmidt
2007-08-10 20:39   ` Segher Boessenkool
2007-08-13  1:05     ` David Gibson
2007-08-11  3:51 ` Olof Johansson
     [not found] <20070823035601.GL7042@localhost.localdomain>
2007-08-23  7:30 ` Benjamin Herrenschmidt
2007-09-14 22:37   ` Josh Boyer
  -- strict thread matches above, loose matches on Subject: below --
2007-05-30  6:17 David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070807062231.GB8351@localhost.localdomain \
    --to=david@gibson.dropbear.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=jdl@freescale.com \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).