From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lixom.net (lixom.net [66.141.50.11]) by ozlabs.org (Postfix) with ESMTP id 1BD4EDDE37 for ; Sat, 11 Aug 2007 13:35:05 +1000 (EST) Date: Fri, 10 Aug 2007 22:51:16 -0500 From: Olof Johansson To: Paul Mackerras , Benjamin Herrenschmidt , Josh Boyer , Jon Loeliger , linuxppc-dev@ozlabs.org Subject: Re: Device tree aware EMAC driver Message-ID: <20070811035116.GA324@lixom.net> References: <20070807062231.GB8351@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070807062231.GB8351@localhost.localdomain> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Aug 07, 2007 at 04:22:31PM +1000, David Gibson wrote: > This driver is designed to sit alongside the old driver (it lies in > drivers/net/ibm_emac and this one in drivers/net/ibm_newemac). The > old driver is left in place to support arch/ppc until arch/ppc itself > reaches its final demise (not too long now, with luck). I would very much prefer if the patch was provided as first a pure copy without changes, then the actual diffs on top of that. The way it is now is just a huge blob that's harder to review than it would otherwise be. -Olof