From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 14 Aug 2007 17:56:13 +1000 From: David Gibson To: Greg KH Subject: Re: [patch 07/12] powerpc: Fix size check for hugetlbfs Message-ID: <20070814075613.GH8791@localhost.localdomain> References: <20070814072244.882283903@mini.kroah.org> <20070814072918.GG15025@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070814072918.GG15025@kroah.com> Cc: Theodore Ts'o , Zwane Mwaikambo , torvalds@linux-foundation.org, Justin Forbes , linux-kernel@vger.kernel.org, Chris Wedgwood , Domenico Andreoli , linuxppc-dev list , Randy Dunlap , Paul Mackerras , Chuck Ebbert , Dave Jones , Michael Krufky , akpm@linux-foundation.org, Chuck Wolber , stable@kernel.org, alan@lxorguk.ukuu.org.uk List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Aug 14, 2007 at 12:29:18AM -0700, Greg KH wrote: > -stable review patch. If anyone has any objections, please let us know. > > ------------------ > From: Benjamin Herrenschmidt > > My "slices" address space management code that was added in 2.6.22 > implementation of get_unmapped_area() doesn't properly check that the > size is a multiple of the requested page size. This allows userland to > create VMAs that aren't a multiple of the huge page size with hugetlbfs > (since hugetlbfs entirely relies on get_unmapped_area() to do that > checking) which leads to a kernel BUG() when such areas are torn down. > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Paul Mackerras > Signed-off-by: Greg Kroah-Hartman Acked-by: David Gibson -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson