From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 21 Aug 2007 12:01:31 +1000 From: David Gibson To: Scott Wood Subject: Re: [PATCH 03/20] bootwrapper: dt_xlate_range() bugfixes Message-ID: <20070821020131.GD15469@localhost.localdomain> References: <20070820173920.GA30546@ld0162-tx32.am.freescale.net> <20070820173946.GB30562@ld0162-tx32.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070820173946.GB30562@ld0162-tx32.am.freescale.net> Cc: linuxppc-dev@ozlabs.org, paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Aug 20, 2007 at 12:39:46PM -0500, Scott Wood wrote: > 1. The check whether ranges fits in the buffer was using elements rather > than bytes. > 2. Empty ranges were not properly treated as transparent, and missing > ranges were treated as transparent. > 3. The loop terminated when translating from the root rather than to. Once > bug #2 was fixed, it failed due to a missing ranges in the root node. > 4. In decoding the ranges property, the #size-cells used was that of > the parent, not the child. > Signed-off-by: Scott Wood Acked-by: David Gibson -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson