From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 21 Aug 2007 12:38:24 +1000 From: David Gibson To: Scott Wood Subject: Re: [PATCH 08/20] bootwrapper: serial_console_init() fixes. Message-ID: <20070821023824.GH15469@localhost.localdomain> References: <20070820173920.GA30546@ld0162-tx32.am.freescale.net> <20070820173954.GG30562@ld0162-tx32.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070820173954.GG30562@ld0162-tx32.am.freescale.net> Cc: linuxppc-dev@ozlabs.org, paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Aug 20, 2007 at 12:39:54PM -0500, Scott Wood wrote: > 1. Search the entire compatible list for serial devices. > > The serial code previously did a simple strcmp on the compatible > node; this fails when the match string is not the first compatible > listed. Use dt_is_compatible() instead. > > 2. Don't call serial_edit_cmdline if getc isn't defined. > > Signed-off-by: Scott Wood Acked-by: David Gibson -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson