From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 23 Aug 2007 12:47:57 +1000 From: David Gibson To: Kumar Gala Subject: Re: asm-ppc header issues when building ARCH=powerpc Message-ID: <20070823024757.GC7042@localhost.localdomain> References: <75EDD900-3B5E-4D08-9311-13B6510EDE6E@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <75EDD900-3B5E-4D08-9311-13B6510EDE6E@kernel.crashing.org> Cc: "linuxppc-dev@ozlabs.org list" , Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Aug 22, 2007 at 10:19:21AM -0500, Kumar Gala wrote: > Guys, > > I was wondering if I could get your help with looking at the > following lists and determining if we have an issue or not related > the following files: > > Getting some classification on these would be good. Possibly > classifications, doesn't build in ARCH=powerpc, remove include, real > issue, etc. > > - k > > ./include/asm-powerpc/irq.h:#include - protected by ! > CONFIG_PPC_MERGE irq.h seems to have a big slab of CONFIG_PPC_MERGE dependent stuff. Looks like a good candidate for splitting into asm-ppc/irq.h and asm-powerpc/irq.h > ./drivers/ide/ppc/mpc8xx.c:#include Since mpc8xx is certainly not PReP, I don't think there's any way it ought to be including residual.h > ./drivers/mtd/maps/tqm834x.c:#include > ./drivers/mtd/maps/pq2fads.c:#include Although these both have an extern of type bd_t (defined in ppcboot.h), afaict they don't actually use it, so these should be removable. Longer term, all these ugly hardcoded map files should be relegated to arch/ppc only, replaced with physmap_of and suitable information in the device tree for arch/powerpc. However, being able to build them on arch/powerpc may be useful during transition. > ./drivers/i2c/busses/i2c-ibm_iic.c:#include This driver will need significant reworking to port to arch/powerpc (similar to the treatment ibm_emac has received). Such rework will remove the dependency on ibm4xx.h and ocp.h > ./drivers/mtd/maps/walnut.c:#include Suspect it's not needed. But in any case, this too should be replaced by physmap_of for arch/powerpc. > ./include/asm-powerpc/irq.h:#include - protected by ! > CONFIG_PPC_MERGE > > ./drivers/mtd/maps/ebony.c:#include Ebony flash now works with physmap_of, so this is only used on arch/ppc. > ./drivers/mtd/maps/ocotea.c:#include As for drivers/mtd/maps/walnut.c. > ./drivers/mtd/nand/ndfc.c:#include This probably also wants rework to make a device-tree-aware arch/powerpc version. > ./include/asm-powerpc/irq.h:#include - protected by ! > CONFIG_PPC_MERGE > > ./drivers/i2c/busses/i2c-ibm_iic.c:#include See above. > ./drivers/net/ucc_geth_mii.c:#include - just bogus, needs > removal > ./drivers/net/ibm_emac/ibm_emac_core.c:#include > ./drivers/net/ibm_emac/ibm_emac_core.h:#include > ./drivers/net/ibm_emac/ibm_emac_tah.h:#include > ./drivers/net/ibm_emac/ibm_emac_phy.c:#include > ./drivers/net/ibm_emac/ibm_emac_mal.c:#include > ./drivers/net/ibm_emac/ibm_emac_zmii.h:#include ibm_emac is arch/ppc only. BenH and my 'ibm_newemac' patch adds a new, device-tree aware arch/powerpc port of this driver. > > ./drivers/macintosh/adb-iop.c:#include I think this is just unnecessary, maybe also for a bunch of the ones below. > ./drivers/char/vme_scc.c:#include > ./drivers/char/serial167.c:#include > ./drivers/serial/dz.c:#include > ./drivers/mtd/devices/ms02-nv.c:#include > ./drivers/net/macsonic.c:#include > ./drivers/net/jazzsonic.c:#include > ./drivers/video/pmag-aa-fb.c:#include > ./drivers/video/maxinefb.c:#include > ./drivers/video/logo/logo.c:#include > ./drivers/video/valkyriefb.c:#include > ./drivers/video/macfb.c:#include > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson