From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>,
"linuxppc-dev@ozlabs.org list" <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: asm-ppc header issues when building ARCH=powerpc
Date: Thu, 23 Aug 2007 12:33:14 -0500 [thread overview]
Message-ID: <20070823173314.GA18412@ld0162-tx32.am.freescale.net> (raw)
In-Reply-To: <20070823024757.GC7042@localhost.localdomain>
On Thu, Aug 23, 2007 at 12:47:57PM +1000, David Gibson wrote:
> > ./drivers/mtd/maps/tqm834x.c:#include <asm/ppcboot.h>
> > ./drivers/mtd/maps/pq2fads.c:#include <asm/ppcboot.h>
>
> Although these both have an extern of type bd_t (defined in
> ppcboot.h), afaict they don't actually use it, so these should be
> removable.
They look like they're using it to me... See the bd->bi_flashstart and
bd->bi_flashsize references in init_pq2fads_mtd.
-Scott
next prev parent reply other threads:[~2007-08-23 17:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-22 15:19 asm-ppc header issues when building ARCH=powerpc Kumar Gala
2007-08-22 16:01 ` Scott Wood
2007-08-22 19:30 ` Josh Boyer
2007-08-23 2:49 ` David Gibson
2007-08-23 3:09 ` Kumar Gala
2007-08-23 2:47 ` David Gibson
2007-08-23 3:22 ` Kumar Gala
2007-08-23 17:33 ` Scott Wood [this message]
2007-08-23 18:00 ` Kumar Gala
2007-08-23 3:33 ` Kumar Gala
2007-08-23 3:33 ` David Gibson
2007-08-23 4:16 ` Kumar Gala
2007-08-23 9:47 ` Geert Uytterhoeven
2007-08-23 18:56 ` Brad Boyer
2007-08-24 7:10 ` Geert Uytterhoeven
2007-08-24 7:24 ` Kumar Gala
2007-08-24 7:24 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070823173314.GA18412@ld0162-tx32.am.freescale.net \
--to=scottwood@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).