From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 3/4] Use strcasecmp() rather than strncasecmp() when determining device node compatibility.
Date: Tue, 28 Aug 2007 09:33:29 -0500 [thread overview]
Message-ID: <20070828093329.575f9b9e@weaponx.rchland.ibm.com> (raw)
In-Reply-To: <20070820163659.GB29912@ld0162-tx32.am.freescale.net>
On Mon, 20 Aug 2007 11:36:59 -0500
Scott Wood <scottwood@freescale.com> wrote:
> The current code assumes "foo-bar" must always be compatible with a node
> compatible with "foo", which breaks device trees where this is not so.
>
> The "case" part is also wrong according to Open Firmware, but it's more
> likely to have drivers and/or device trees depending on it, and thus
> needs to be handled more carefully.
After wasting about an hour with git bisect, I finally realized that
this patch "caught" an error in the walnut patches I'm working on (by
making it not boot). So thanks!
josh
next prev parent reply other threads:[~2007-08-28 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 16:36 [PATCH 1/4] Whitespace cleanup in arch/powerpc Scott Wood
2007-08-20 16:36 ` [PATCH 2/4] Add clrbits8 and setbits8 Scott Wood
2007-08-20 16:36 ` [PATCH 3/4] Use strcasecmp() rather than strncasecmp() when determining device node compatibility Scott Wood
2007-08-28 14:33 ` Josh Boyer [this message]
2007-08-20 16:38 ` [PATCH 4/4] fsl_soc.c cleanup Scott Wood
2007-08-29 22:33 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070828093329.575f9b9e@weaponx.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).