From: Stefan Roese <sr@denx.de>
To: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper
Date: Wed, 29 Aug 2007 14:28:23 +0200 [thread overview]
Message-ID: <200708291428.23522.sr@denx.de> (raw)
In-Reply-To: <46D56226.8020500@ru.mvista.com>
On Wednesday 29 August 2007, Valentine Barshak wrote:
> >> +#define DDR_GET_VAL(val, mask, shift) (((val) >> (shift)) & (mask))
> >
> > Hm. Having these as just DDR_... seems like it would lead to confusion
> > if there are other DDR controllers that get added later. But I'm not
> > too picky either way.
>
> What names would you suggest? DDR_DENALI_... looks too long :)
> The names have been taken from the docs, I've just prefixed them with DDR_.
It's such a generic macro and not Denali or even SDRAM specific. So it really
should be no problem to keep it as is.
Just my 0.02$.
Best regards,
Stefan
next prev parent reply other threads:[~2007-08-29 12:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-28 16:53 [PATCH 0/4] PowerPC 440EPx: Initial Sequoia support take 3 Valentine Barshak
2007-08-28 16:56 ` [PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper Valentine Barshak
2007-08-28 18:09 ` Josh Boyer
2007-08-29 12:10 ` Valentine Barshak
2007-08-29 12:28 ` Stefan Roese [this message]
2007-08-29 12:26 ` Josh Boyer
2007-08-29 6:33 ` David Gibson
2007-08-29 12:13 ` Valentine Barshak
2007-08-28 16:58 ` [PATCH 2/4] PowerPC 440EPx: Sequoia device tree Valentine Barshak
2007-08-28 17:00 ` [PATCH 3/4] PowerPC 440EPx: Sequoia board support Valentine Barshak
2007-08-28 17:48 ` Josh Boyer
2007-08-28 17:50 ` Valentine Barshak
2007-08-28 18:14 ` Olof Johansson
2007-08-28 19:13 ` Josh Boyer
2007-08-28 17:01 ` [PATCH 4/4] PowerPC 440EPx: Sequoia defconfig Valentine Barshak
-- strict thread matches above, loose matches on Subject: below --
2007-08-29 13:35 [PATCH 0/4] PowerPC 440EPx: Initial Sequoia support Valentine Barshak
2007-08-29 13:38 ` [PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper Valentine Barshak
2007-08-30 0:37 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708291428.23522.sr@denx.de \
--to=sr@denx.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).