From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 30 Aug 2007 10:58:00 +1000 From: David Gibson To: Scott Wood Subject: Re: [PATCH 3/3] Add early debug console for CPM serial ports. Message-ID: <20070830005800.GD22844@localhost.localdomain> References: <20070828201127.GA24068@ld0162-tx32.am.freescale.net> <20070828201621.GC24210@ld0162-tx32.am.freescale.net> <20070829054540.GD3206@localhost.localdomain> <20070829140239.GC30184@ld0162-tx32.am.freescale.net> <20070829195837.GA6818@ld0162-tx32.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070829195837.GA6818@ld0162-tx32.am.freescale.net> Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Aug 29, 2007 at 02:58:37PM -0500, Scott Wood wrote: > On Wed, Aug 29, 2007 at 09:02:39AM -0500, Scott Wood wrote: > > > > # Temporary hack until we have migrated to asm-powerpc > > > > ifeq ($(ARCH),powerpc) > > > > +obj-$(CONFIG_CPM1)$(CONFIG_CPM2) += cpm_common.o > > > > > > Uh.. I don't think this will work properly. If CONFIG_CPM1 and > > > CONFIG_CPM2 are both enabled, it will set obj-yy rather than obj-y. > > > > The assumption was that CPM1 and CPM2 are never going to both be enabled, > > as CPM1 only exists on hardware with a unique MMU. > > > > I could add an obj-y += $(obj-yy) if you like, though. > > On second thought, I'll just add a CONFIG_CPM that CPM1 and CPM2 select; > that'll make things easier for further consolidation. Ah, yes, that's much nicer. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson