From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Thomas Klein <tklein@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
Joachim Fenkes <fenkes@de.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Paul Mackerras <pmac@au1.ibm.com>,
Christoph Raisch <raisch@de.ibm.com>,
Paul Mackerras <paulus@samba.org>,
Stefan Roscher <stefan.roscher@de.ibm.com>
Subject: Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions
Date: Thu, 30 Aug 2007 20:22:23 +0200 [thread overview]
Message-ID: <200708302022.24167.arnd@arndb.de> (raw)
In-Reply-To: <200708291815.18197.fenkes@de.ibm.com>
On Wednesday 29 August 2007, Joachim Fenkes wrote:
> Previously, ibmebus derived a device's bus_id from its location code. The
> location code is not guaranteed to be unique, so we might get bus_id
> collisions if two devices share the same location code. The OFDT full_name,
> however, is unique, so we use that instead.
>
> Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
Actually, I think it would be much better to convert the code to be more
like of_platform_device, or to even replace all of ibmebus with that.
The whole logic of dynamically adding and removing device is rather bogus,
and it prevents autoloading of device drivers. of_platform_make_bus_id
is the function that is responsible for creating unique names over there.
Arnd <><
next prev parent reply other threads:[~2007-08-30 18:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-29 16:15 [PATCH 2.6.23] ibmebus: Prevent bus_id collisions Joachim Fenkes
2007-08-29 18:12 ` Nathan Lynch
2007-08-29 18:33 ` jschopp
2007-08-30 14:00 ` Joachim Fenkes
2007-08-30 17:56 ` Nathan Lynch
2007-08-30 20:36 ` Joel Schopp
2007-08-30 21:28 ` Linas Vepstas
2007-08-31 8:57 ` Joachim Fenkes
2007-08-30 18:22 ` Arnd Bergmann [this message]
2007-08-31 14:34 ` Joachim Fenkes
2007-08-31 17:08 ` Arnd Bergmann
2007-08-31 17:46 ` Joachim Fenkes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708302022.24167.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=fenkes@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=pmac@au1.ibm.com \
--cc=raisch@de.ibm.com \
--cc=stefan.roscher@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).