From: David Gibson <david@gibson.dropbear.id.au>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/3] bootwrapper: In cuImage, print message for ENET devices not found in tree
Date: Fri, 31 Aug 2007 12:43:56 +1000 [thread overview]
Message-ID: <20070831024356.GA19271@localhost.localdomain> (raw)
In-Reply-To: <20070830202618.9927.32588.stgit@trillian.cg.shawcable.net>
On Thu, Aug 30, 2007 at 02:26:18PM -0600, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> CC: Scott Wood <scottwood@freescale.com>
> CC: Kumar Gala <galak@kernel.crashing.org>
> CC: David Gibson <david@gibson.dropbear.id.au>
Hrm... I thought Scott had deliberately removed that message in his
patch set, to work with the way PlanetCore generates Ethernet
addresses.
> ---
>
> arch/powerpc/boot/devtree.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/powerpc/boot/devtree.c b/arch/powerpc/boot/devtree.c
> index e1b8122..8451a1c 100644
> --- a/arch/powerpc/boot/devtree.c
> +++ b/arch/powerpc/boot/devtree.c
> @@ -99,14 +99,14 @@ void __dt_fixup_mac_addresses(u32 startindex, ...)
> while ((addr = va_arg(ap, const u8 *))) {
> devp = find_node_by_prop_value(NULL, "linux,network-index",
> (void*)&index, sizeof(index));
> -
> - printf("ENET%d: local-mac-address <-"
> - " %02x:%02x:%02x:%02x:%02x:%02x\n\r", index,
> - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]);
> -
> - if (devp)
> + if (devp) {
> + printf("ENET%d: local-mac-address <-"
> + " %02x:%02x:%02x:%02x:%02x:%02x\n\r", index,
> + addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]);
> setprop(devp, "local-mac-address", addr, 6);
> -
> + } else {
> + printf("ENET%d: no device in tree\n\r", index);
> + }
> index++;
> }
> va_end(ap);
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-08-31 2:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 20:26 [PATCH 1/3] bootwrapper: In cuImage, print message for ENET devices not found in tree Grant Likely
2007-08-30 20:26 ` [PATCH 2/3] mpc8349: Add linux, network-index to ethernet nodes in device tree Grant Likely
2007-08-31 2:44 ` David Gibson
2007-08-30 20:26 ` [PATCH 3/3] mpc8349emitx(gp): update defconfigs for 2.6.23 Grant Likely
2007-08-31 2:43 ` David Gibson [this message]
2007-08-31 4:14 ` [PATCH 1/3] bootwrapper: In cuImage, print message for ENET devices not found in tree Grant Likely
2007-08-31 4:25 ` David Gibson
2007-08-31 15:29 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070831024356.GA19271@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).