linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 6/9] bootwrapper: Add a zImage.bin.<platform> target.
Date: Fri, 31 Aug 2007 13:24:05 +1000	[thread overview]
Message-ID: <20070831032405.GJ19271@localhost.localdomain> (raw)
In-Reply-To: <20070830142115.GB24123@ld0162-tx32.am.freescale.net>

On Thu, Aug 30, 2007 at 09:21:15AM -0500, Scott Wood wrote:
> On Thu, Aug 30, 2007 at 10:34:09AM +1000, David Gibson wrote:
> > Hrm.. I think the --binary option at least should be removed, and
> > subsumed into the platform id - all other binary formats are selected
> > by the platform name at present.
> > 
> > And I think it's probably best to do that for --fixed-entry as well,
> > although it's a bit less clear there.
> 
> I'm not particularly fond of having huge platform switch blocks in the
> wrapper script -- if it can be reasonably parameterized, why not do so?

Because I'd prefer to keep as much of the per-platform details (what
binary format is needed and so forth) concentrated in wrapper, rather
than scattered across multiple places.  I agree we're not really doing
it the best way - I had some ideas for a nicer way to rewrite wrapper,
but I haven't had a chance to implement it yet.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2007-08-31  3:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-29 16:45 [PATCH 1/9] bootwrapper: flatdevtree fixes Scott Wood
2007-08-29 16:46 ` [PATCH 2/9] bootwrapper: Add strtoull() Scott Wood
2007-08-30  0:30   ` David Gibson
2007-08-30 15:52   ` Milton Miller
2007-08-30 16:16     ` Scott Wood
2007-08-29 16:46 ` [PATCH 3/9] bootwrapper: Add get_path() Scott Wood
2007-08-30  0:30   ` David Gibson
2007-08-29 16:47 ` [PATCH 4/9] bootwrapper: Move strncmp() from flatdevtree_env.h to string.S/string.h Scott Wood
2007-08-30  0:31   ` David Gibson
2007-08-29 16:47 ` [PATCH 6/9] bootwrapper: Add a zImage.bin.<platform> target Scott Wood
2007-08-30  0:34   ` David Gibson
2007-08-30 14:21     ` Scott Wood
2007-08-31  3:24       ` David Gibson [this message]
2007-08-29 16:47 ` [PATCH 7/9] bootwrapper: Only print MAC addresses when the node is actually present Scott Wood
2007-08-30  0:34   ` David Gibson
2007-08-29 16:47 ` [PATCH 8/9] bootwrapper: Add fsl_get_immr() and 8xx/pq2 clock functions Scott Wood
2007-08-29 16:47 ` [PATCH 9/9] bootwrapper: Use fsl_get_immr() in cuboot-pq2.c Scott Wood
2007-08-30  0:28 ` [PATCH 1/9] bootwrapper: flatdevtree fixes David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070831032405.GJ19271@localhost.localdomain \
    --to=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).