From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 31 Aug 2007 13:24:05 +1000 From: David Gibson To: Scott Wood Subject: Re: [PATCH 6/9] bootwrapper: Add a zImage.bin. target. Message-ID: <20070831032405.GJ19271@localhost.localdomain> References: <20070829164534.GA31585@ld0162-tx32.am.freescale.net> <20070829164741.GD31640@ld0162-tx32.am.freescale.net> <20070830003409.GE21072@localhost.localdomain> <20070830142115.GB24123@ld0162-tx32.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070830142115.GB24123@ld0162-tx32.am.freescale.net> Cc: linuxppc-dev@ozlabs.org, paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Aug 30, 2007 at 09:21:15AM -0500, Scott Wood wrote: > On Thu, Aug 30, 2007 at 10:34:09AM +1000, David Gibson wrote: > > Hrm.. I think the --binary option at least should be removed, and > > subsumed into the platform id - all other binary formats are selected > > by the platform name at present. > > > > And I think it's probably best to do that for --fixed-entry as well, > > although it's a bit less clear there. > > I'm not particularly fond of having huge platform switch blocks in the > wrapper script -- if it can be reasonably parameterized, why not do so? Because I'd prefer to keep as much of the per-platform details (what binary format is needed and so forth) concentrated in wrapper, rather than scattered across multiple places. I agree we're not really doing it the best way - I had some ideas for a nicer way to rewrite wrapper, but I haven't had a chance to implement it yet. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson