From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 5D86ADDE1E for ; Wed, 5 Sep 2007 07:28:53 +1000 (EST) Date: Wed, 5 Sep 2007 00:43:34 +0400 From: Vitaly Bordug To: Scott Wood Subject: Re: [PATCH 3/9] cpm2: Add SCCs to cpm2_clk_setup(), and cpm2_smc_clk_setup(). Message-ID: <20070905004334.6e8d0677@localhost.localdomain> In-Reply-To: <20070830201500.GB5144@ld0162-tx32.am.freescale.net> References: <20070828201127.GA24068@ld0162-tx32.am.freescale.net> <20070828201922.GC24329@ld0162-tx32.am.freescale.net> <20070830022548.6e0ce296@localhost.localdomain> <20070830201500.GB5144@ld0162-tx32.am.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 30 Aug 2007 15:15:00 -0500 Scott Wood wrote: > On Thu, Aug 30, 2007 at 02:25:48AM +0400, Vitaly Bordug wrote: > > I would have it in the same patch, that adds clocking stuff to 8xx. > > I was trying to keep the 8xx and 82xx patchsets reasonably separate. > > > And maybe in the same, segregate source rather then having it in the > > foo_common.c, to ease fix/update/rework. > > I'm not sure I understand what you mean -- where do you want the code > to go? > Thinking once again about this, It looks good the way it is, another way is prolly overkill so nm. -- Sincerely, Vitaly