From: David Gibson <dwg@au1.ibm.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [patch 2/6] cuimage for Bamboo board
Date: Wed, 5 Sep 2007 11:10:45 +1000 [thread overview]
Message-ID: <20070905011045.GC17189@localhost.localdomain> (raw)
In-Reply-To: <1188826931.3772.11.camel@localhost.localdomain>
On Mon, Sep 03, 2007 at 08:42:11AM -0500, Josh Boyer wrote:
> On Mon, 2007-09-03 at 11:01 +1000, David Gibson wrote:
> > On Fri, Aug 31, 2007 at 03:04:51PM -0500, Josh Boyer wrote:
> > > Add a cuboot wrapper for the Bamboo board. This also removes some obsoleted
> > > linker declarations that have been moved into ops.h
> > >
> > > Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
> >
> > [snip]
> > > --- linux-2.6.orig/arch/powerpc/boot/bamboo.c
> > > +++ linux-2.6/arch/powerpc/boot/bamboo.c
> > > @@ -24,8 +24,7 @@
> > > #include "4xx.h"
> > > #include "44x.h"
> > >
> > > -extern char _dtb_start[];
> > > -extern char _dtb_end[];
> > > +static u8 *bamboo_mac0, *bamboo_mac1;
> > >
> > > static void bamboo_fixups(void)
> > > {
> > > @@ -34,12 +33,16 @@ static void bamboo_fixups(void)
> > > ibm440ep_fixup_clocks(sysclk, 11059200);
> > > ibm4xx_fixup_memsize();
> > > ibm4xx_quiesce_eth((u32 *)0xef600e00, (u32 *)0xef600f00);
> > > + if (bamboo_mac0 && bamboo_mac1)
> > > + dt_fixup_mac_addresses(bamboo_mac0, bamboo_mac1);
> >
> > Bit ugly that you only set the MAC address for any ethernet if they're
> > supplied for every ethernet.
>
> Good point. Will fix.
>
> > > simple_alloc_init(_end, avail_ram, 32, 64);
> > > - bamboo_init();
> > > + bamboo_init(NULL, NULL);
> >
> > There must surely be a way to get the MAC addresses out of OpenBIOS...
>
> Probably. I just need to find out where they are stored.
It's not buried somewhere in the arch/ppc/boot code?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-09-05 1:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 20:04 [patch 0/6] Current 4xx patch queue Josh Boyer
2007-08-31 20:04 ` [patch 1/6] Fix bus probe on Bamboo board Josh Boyer
2007-09-03 0:58 ` David Gibson
2007-08-31 20:04 ` [patch 2/6] cuimage for " Josh Boyer
2007-09-03 1:01 ` David Gibson
2007-09-03 13:42 ` Josh Boyer
2007-09-05 1:10 ` David Gibson [this message]
2007-09-05 0:40 ` Josh Boyer
2007-09-05 5:46 ` David Gibson
2007-09-05 5:53 ` Josh Boyer
2007-09-05 16:42 ` Josh Boyer
2007-09-07 3:26 ` David Gibson
2007-09-07 1:06 ` David Gibson
2007-08-31 20:04 ` [patch 3/6] Walnut DTS Josh Boyer
2007-09-03 1:08 ` David Gibson
2007-09-02 13:59 ` Josh Boyer
2007-09-04 12:42 ` Josh Boyer
2007-09-05 2:36 ` David Gibson
2007-09-05 0:39 ` Josh Boyer
2007-09-05 11:38 ` Segher Boessenkool
2007-09-05 16:33 ` Josh Boyer
2007-09-07 1:07 ` David Gibson
2007-08-31 20:04 ` [patch 4/6] Walnut defconfig Josh Boyer
2007-08-31 20:04 ` [patch 5/6] Walnut board support Josh Boyer
2007-09-03 1:11 ` David Gibson
2007-09-02 13:59 ` Josh Boyer
2007-09-04 12:37 ` Josh Boyer
2007-09-05 1:09 ` David Gibson
2007-09-05 3:01 ` David Gibson
2007-08-31 20:04 ` [patch 6/6] Walnut zImage wrapper Josh Boyer
2007-09-03 1:13 ` David Gibson
2007-09-02 13:58 ` Josh Boyer
2007-09-05 16:36 ` Josh Boyer
2007-09-07 1:22 ` David Gibson
2007-09-24 7:49 ` Wolfgang Grandegger
2007-09-24 12:03 ` Josh Boyer
2007-09-24 12:20 ` Wolfgang Grandegger
2007-09-24 12:25 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070905011045.GC17189@localhost.localdomain \
--to=dwg@au1.ibm.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).