From: David Gibson <david@gibson.dropbear.id.au>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 1/5] Add Freescale DMA and DMA channel to Documentation/powerpc/booting-without-of.txt file.
Date: Mon, 10 Sep 2007 13:25:29 +1000 [thread overview]
Message-ID: <20070910032529.GA27828@localhost.localdomain> (raw)
In-Reply-To: <3b29878a7d3d1b14f84b5d3b182cdb98@kernel.crashing.org>
On Fri, Sep 07, 2007 at 04:43:35PM +0200, Segher Boessenkool wrote:
> > + l) Freescale DMA
>
> > + - compatible : Should be "fsl,dma".
>
> Please choose some more specific name. "fsl,mpc8540-dma" would
> be a reasonable choice perhaps.
More precisely, the compatible property should always have an specific
entry based on the exact chip the DMA engine resides in, as well as a
more general entry for any fsl dma engine of this type.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-09-10 3:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 10:53 [PATCH 0/5] DMA engine driver for Freescale MPC85xx processors Zhang Wei
2007-09-07 10:53 ` [PATCH 1/5] Add Freescale DMA and DMA channel to Documentation/powerpc/booting-without-of.txt file Zhang Wei
2007-09-07 10:53 ` [PATCH 2/5] Add Freescale DMA engine driver maintainer Zhang Wei
2007-09-07 10:53 ` [PATCH 3/5] Add DMA of-node to mpc8641hpcn board dts Zhang Wei
2007-09-07 10:53 ` [PATCH 4/5] Add of-device and DMA bus support to MPC8641HPCN board Zhang Wei
2007-09-07 21:10 ` [PATCH 3/5] Add DMA of-node to mpc8641hpcn board dts Scott Wood
2007-09-10 3:27 ` [PATCH 2/5] Add Freescale DMA engine driver maintainer David Gibson
2007-09-11 10:07 ` Zhang Wei-r63237
2007-09-07 14:43 ` [PATCH 1/5] Add Freescale DMA and DMA channel to Documentation/powerpc/booting-without-of.txt file Segher Boessenkool
2007-09-07 15:31 ` Scott Wood
2007-09-07 16:30 ` Segher Boessenkool
2007-09-10 3:25 ` David Gibson [this message]
2007-09-11 10:01 ` Zhang Wei-r63237
2007-09-11 14:19 ` Scott Wood
2007-09-12 10:13 ` Zhang Wei-r63237
2007-09-12 15:19 ` Scott Wood
2007-09-13 2:09 ` Segher Boessenkool
2007-09-13 14:52 ` Scott Wood
2007-09-13 15:11 ` Kumar Gala
2007-09-13 18:55 ` Segher Boessenkool
2007-09-13 18:59 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070910032529.GA27828@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).