[PATCH] export new __io{re,un}map_at() symbols

[PATCH] export new __io{re,un}map_at() symbols

[Olof Johansson]

Export new __io{re,un}map_at() symbols so modules can use them.


Signed-off-by: Olof Johansson <olof@lixom.net>


Index: mainline/arch/powerpc/mm/pgtable_64.c
===================================================================
--- mainline.orig/arch/powerpc/mm/pgtable_64.c
+++ mainline/arch/powerpc/mm/pgtable_64.c
@@ -228,5 +228,7 @@ void iounmap(volatile void __iomem *toke
 EXPORT_SYMBOL(ioremap);
 EXPORT_SYMBOL(ioremap_flags);
 EXPORT_SYMBOL(__ioremap);
+EXPORT_SYMBOL(__ioremap_at);
 EXPORT_SYMBOL(iounmap);
 EXPORT_SYMBOL(__iounmap);
+EXPORT_SYMBOL(__iounmap_at);

Re: [PATCH] export new __io{re,un}map_at() symbols

[Paul Mackerras]

Olof Johansson writes:

> Export new __io{re,un}map_at() symbols so modules can use them.

What module wants to use these?  How is it going to work out what
effective address to use?

Paul.

Re: [PATCH] export new __io{re,un}map_at() symbols

[Olof Johansson]

Hi,

On Tue, Sep 11, 2007 at 07:57:52AM +1000, Paul Mackerras wrote:
> Olof Johansson writes:
> 
> > Export new __io{re,un}map_at() symbols so modules can use them.
> 
> What module wants to use these?  How is it going to work out what
> effective address to use?

electra_cf uses it, that driver is currently in -mm including below
update to use benh's rewritten interfaces:

http://patchwork.ozlabs.org/linuxppc/patch?id=13237

It gets the effective addresses to use out of the device tree.


-Olof

Re: [PATCH] export new __io{re,un}map_at() symbols

[Paul Mackerras]

Olof Johansson writes:

> electra_cf uses it, that driver is currently in -mm including below
> update to use benh's rewritten interfaces:
> 
> http://patchwork.ozlabs.org/linuxppc/patch?id=13237
> 
> It gets the effective addresses to use out of the device tree.

Huh?  What does firmware (or the device tree) know about how the
kernel uses effective addresses?

Paul.

Re: [PATCH] export new __io{re,un}map_at() symbols

[Olof Johansson]

On Tue, Sep 11, 2007 at 09:10:20AM +1000, Paul Mackerras wrote:
> Olof Johansson writes:
> 
> > electra_cf uses it, that driver is currently in -mm including below
> > update to use benh's rewritten interfaces:
> > 
> > http://patchwork.ozlabs.org/linuxppc/patch?id=13237
> > 
> > It gets the effective addresses to use out of the device tree.
> 
> Huh?  What does firmware (or the device tree) know about how the
> kernel uses effective addresses?

Oh, sorry, of course it doesn't (I was thinking of the physical address
but writing effective).

I get effective address by allocating it with __get_vm_area same way
the pseries pci hotplug does:

	area = __get_vm_area(cf->io_size, 0, PHB_IO_BASE, PHB_IO_END);
	if (area == NULL)
		return -ENOMEM;

	cf->io_virt = (void __iomem *)(area->addr);


-Olof