From: tony@bakeyournoodle.com (Tony Breeds)
To: Milton Miller <miltonm@bga.com>
Cc: ppcdev <linuxppc-dev@ozlabs.org>
Subject: Re: [RFC/PATCH] Implement {read,update}_persistent_clock. v2
Date: Wed, 12 Sep 2007 14:56:20 +1000 [thread overview]
Message-ID: <20070912045620.GI9814@bakeyournoodle.com> (raw)
In-Reply-To: <4d781cd1a4751e20098cae29aa4d2b60@bga.com>
On Tue, Sep 11, 2007 at 09:34:13AM -0500, Milton Miller wrote:
> Previously we called ppc_md.get_boot_time at most once. How about
> moving the check for it into the if (first) block?
Yup on investigatiion it looks like moving it inside the "if (fist)" is
safe.
> Have you tested with a platform that doesn't implement get_rtc_time?
Well no I haven't. AFAICT without my patch read_persistent_clock() is a
weak symbol that always returns 0. So any platform that doesn't have a
ppc_md.get_boot_time() or ppc_md.get_rtc_time() will still get a 0 at
all the call sites.
I'll locate a machine and verify I'm not making things worse.
Yours Tony
linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
next prev parent reply other threads:[~2007-09-12 4:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 7:49 [RFC/PATCH] Implement {read,update}_persistent_clock Tony Breeds
2007-09-11 8:17 ` [RFC/PATCH] Implement {read,update}_persistent_clock. v2 Tony Breeds
2007-09-11 14:34 ` Milton Miller
2007-09-12 4:56 ` Tony Breeds [this message]
2007-09-11 8:28 ` [RFC/PATCH] Implement {read,update}_persistent_clock Gabriel Paubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912045620.GI9814@bakeyournoodle.com \
--to=tony@bakeyournoodle.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).