From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michael Neuling <mikey@neuling.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
paulus@samba.org, Alan Cox <alan@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH] powerpc: add new required termio functions
Date: Wed, 12 Sep 2007 13:52:57 +0200 [thread overview]
Message-ID: <20070912115257.GC7858@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20070912113409.GA7253@infradead.org>
On Wed, Sep 12, 2007 at 12:34:09PM +0100, Christoph Hellwig wrote:
> On Wed, Sep 12, 2007 at 04:01:09AM -0700, Andrew Morton wrote:
> > On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> >
> > > On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote:
> > > > The "tty: termios locking functions break with new termios type" patch
> > > > (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile.
> > > > [...]
> > > > I'm guessing other architectures are broken too?
> > >
> > > FWIW, the above quoted patch breaks s390 as well.
> >
> > Does this fix it?
Yes, it does.
> I might be missing something, but the the right fix is probably to
> apply the arch patches from Alan to powerpc and s390. We don't want to
> be left over without all the nice termios features on these platforms,
> do we?
But not in rc6 timeframe, I would guess?
next prev parent reply other threads:[~2007-09-12 11:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 2:04 [PATCH] powerpc: add new required termio functions Michael Neuling
2007-09-12 2:17 ` Linus Torvalds
2007-09-12 2:33 ` Tony Breeds
2007-09-12 2:34 ` Michael Neuling
2007-09-12 2:19 ` Geoff Levand
2007-09-12 10:20 ` Heiko Carstens
2007-09-12 11:01 ` Andrew Morton
2007-09-12 11:16 ` Michael Neuling
2007-09-12 11:34 ` Christoph Hellwig
2007-09-12 11:52 ` Heiko Carstens [this message]
2007-09-12 13:49 ` Christoph Hellwig
2007-09-14 14:20 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912115257.GC7858@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).