* [PATCH] [POWERPC][RFC] mpc8xx: fix build with CONFIG_MODULES=y @ 2007-09-18 12:07 Anton Vorontsov 2007-09-18 12:29 ` [PATCH] [POWERPC][RFC] sysdev/commproc.c: fix build caused by undefined symbols Anton Vorontsov 2007-09-18 12:29 ` [PATCH] [POWERPC] sysdev/commproc.c: fix copy-n-paste problem Anton Vorontsov 0 siblings, 2 replies; 5+ messages in thread From: Anton Vorontsov @ 2007-09-18 12:07 UTC (permalink / raw) To: linuxppc-dev Hi all, It seems there is no __res in the arch/powerpc. How it was used in the new tree, can we now safely remove it? At least kernel builds with that patch. Thanks, Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> --- arch/powerpc/kernel/ppc_ksyms.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c index 430c502..b4163c3 100644 --- a/arch/powerpc/kernel/ppc_ksyms.c +++ b/arch/powerpc/kernel/ppc_ksyms.c @@ -180,9 +180,6 @@ EXPORT_SYMBOL(cacheable_memcpy); EXPORT_SYMBOL(cpm_install_handler); EXPORT_SYMBOL(cpm_free_handler); #endif /* CONFIG_8xx */ -#if defined(CONFIG_8xx) -EXPORT_SYMBOL(__res); -#endif #ifdef CONFIG_PPC32 EXPORT_SYMBOL(next_mmu_context); -- 1.5.0.6 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] [POWERPC][RFC] sysdev/commproc.c: fix build caused by undefined symbols 2007-09-18 12:07 [PATCH] [POWERPC][RFC] mpc8xx: fix build with CONFIG_MODULES=y Anton Vorontsov @ 2007-09-18 12:29 ` Anton Vorontsov 2007-09-18 14:26 ` Kumar Gala 2007-09-18 12:29 ` [PATCH] [POWERPC] sysdev/commproc.c: fix copy-n-paste problem Anton Vorontsov 1 sibling, 1 reply; 5+ messages in thread From: Anton Vorontsov @ 2007-09-18 12:29 UTC (permalink / raw) To: linuxppc-dev cpm_install_handler and cpm_free_handler neither used nor defined for arch/powerpc. This causes MPC8xx build failure, patch used to fix that. Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> --- arch/powerpc/kernel/ppc_ksyms.c | 5 ----- include/asm-powerpc/commproc.h | 3 --- 2 files changed, 0 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c index b4163c3..4d28774 100644 --- a/arch/powerpc/kernel/ppc_ksyms.c +++ b/arch/powerpc/kernel/ppc_ksyms.c @@ -176,11 +176,6 @@ EXPORT_SYMBOL(console_drivers); EXPORT_SYMBOL(cacheable_memcpy); #endif -#ifdef CONFIG_8xx -EXPORT_SYMBOL(cpm_install_handler); -EXPORT_SYMBOL(cpm_free_handler); -#endif /* CONFIG_8xx */ - #ifdef CONFIG_PPC32 EXPORT_SYMBOL(next_mmu_context); EXPORT_SYMBOL(set_context); diff --git a/include/asm-powerpc/commproc.h b/include/asm-powerpc/commproc.h index 3972487..0d92012 100644 --- a/include/asm-powerpc/commproc.h +++ b/include/asm-powerpc/commproc.h @@ -686,7 +686,4 @@ typedef struct risc_timer_pram { #define CICR_IEN ((uint)0x00000080) /* Int. enable */ #define CICR_SPS ((uint)0x00000001) /* SCC Spread */ -extern void cpm_install_handler(int vec, void (*handler)(void *), void *dev_id); -extern void cpm_free_handler(int vec); - #endif /* __CPM_8XX__ */ -- 1.5.0.6 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] [POWERPC][RFC] sysdev/commproc.c: fix build caused by undefined symbols 2007-09-18 12:29 ` [PATCH] [POWERPC][RFC] sysdev/commproc.c: fix build caused by undefined symbols Anton Vorontsov @ 2007-09-18 14:26 ` Kumar Gala 2007-09-19 11:33 ` [PATCH] [POWERPC] Fix various build errors seen on MPC885ADS with CONFIG_MODULES=y Anton Vorontsov 0 siblings, 1 reply; 5+ messages in thread From: Kumar Gala @ 2007-09-18 14:26 UTC (permalink / raw) To: Anton Vorontsov; +Cc: linuxppc-dev On Sep 18, 2007, at 7:29 AM, Anton Vorontsov wrote: > cpm_install_handler and cpm_free_handler neither used nor defined > for arch/powerpc. > > This causes MPC8xx build failure, patch used to fix that. can you add the __res fix, and EXPORT() and do these three as one patch and improve the commit message. I'm guessing this all shows up when we try to build with CONFIG_MODULES=y. Put the actual compile failures in the commit message. - k ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] [POWERPC] Fix various build errors seen on MPC885ADS with CONFIG_MODULES=y 2007-09-18 14:26 ` Kumar Gala @ 2007-09-19 11:33 ` Anton Vorontsov 0 siblings, 0 replies; 5+ messages in thread From: Anton Vorontsov @ 2007-09-19 11:33 UTC (permalink / raw) To: Kumar Gala; +Cc: linuxppc-dev On Tue, Sep 18, 2007 at 09:26:18AM -0500, Kumar Gala wrote: > > On Sep 18, 2007, at 7:29 AM, Anton Vorontsov wrote: > >> cpm_install_handler and cpm_free_handler neither used nor defined >> for arch/powerpc. >> >> This causes MPC8xx build failure, patch used to fix that. > > can you add the __res fix, and EXPORT() and do these three as one patch and > improve the commit message. I'm guessing this all shows up when we try to > build with CONFIG_MODULES=y. Put the actual compile failures in the commit > message. > > - k > Done, thanks. - - - - From: Anton Vorontsov <avorontsov@ru.mvista.com> Subject: [POWERPC] Fix various build errors seen on MPC885ADS with CONFIG_MODULES=y CC arch/powerpc/kernel/ppc_ksyms.o arch/powerpc/kernel/ppc_ksyms.c:184: error: `__res' undeclared here (not in a function) arch/powerpc/kernel/ppc_ksyms.c:184: warning: type defaults to `int' in declaration of `__res' make[1]: *** [arch/powerpc/kernel/ppc_ksyms.o] Error 1 make: *** [arch/powerpc/kernel] Error 2 There is no __res in the arch/powerpc tree. LD .tmp_vmlinux1 arch/powerpc/kernel/built-in.o(__ksymtab+0x1b0): undefined reference to `cpm_free_handler' arch/powerpc/kernel/built-in.o(__ksymtab+0x1b8): undefined reference to `cpm_install_handler' make: *** [.tmp_vmlinux1] Error 1 cpm_install_handler and cpm_free_handler neither used nor defined for arch/powerpc. CC arch/powerpc/sysdev/commproc.o arch/powerpc/sysdev/commproc.c:390: error: redefinition of '__kstrtab_cpm_dpram_addr' arch/powerpc/sysdev/commproc.c:384: error: previous definition of '__kstrtab_cpm_dpram_addr' was here arch/powerpc/sysdev/commproc.c:390: error: redefinition of '__ksymtab_cpm_dpram_addr' arch/powerpc/sysdev/commproc.c:384: error: previous definition of '__ksymtab_cpm_dpram_addr' was here make[1]: *** [arch/powerpc/sysdev/commproc.o] Error 1 make: *** [arch/powerpc/sysdev] Error 2 Second export should be for cpm_dpram_phys not cpm_dpram_addr, this is copy-n-paste problem. Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> --- arch/powerpc/kernel/ppc_ksyms.c | 8 -------- arch/powerpc/sysdev/commproc.c | 2 +- include/asm-powerpc/commproc.h | 3 --- 3 files changed, 1 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c index 430c502..4d28774 100644 --- a/arch/powerpc/kernel/ppc_ksyms.c +++ b/arch/powerpc/kernel/ppc_ksyms.c @@ -176,14 +176,6 @@ EXPORT_SYMBOL(console_drivers); EXPORT_SYMBOL(cacheable_memcpy); #endif -#ifdef CONFIG_8xx -EXPORT_SYMBOL(cpm_install_handler); -EXPORT_SYMBOL(cpm_free_handler); -#endif /* CONFIG_8xx */ -#if defined(CONFIG_8xx) -EXPORT_SYMBOL(__res); -#endif - #ifdef CONFIG_PPC32 EXPORT_SYMBOL(next_mmu_context); EXPORT_SYMBOL(set_context); diff --git a/arch/powerpc/sysdev/commproc.c b/arch/powerpc/sysdev/commproc.c index b562afc..160a8b4 100644 --- a/arch/powerpc/sysdev/commproc.c +++ b/arch/powerpc/sysdev/commproc.c @@ -387,4 +387,4 @@ uint cpm_dpram_phys(u8* addr) { return (dpram_pbase + (uint)(addr - dpram_vbase)); } -EXPORT_SYMBOL(cpm_dpram_addr); +EXPORT_SYMBOL(cpm_dpram_phys); diff --git a/include/asm-powerpc/commproc.h b/include/asm-powerpc/commproc.h index 3972487..0d92012 100644 --- a/include/asm-powerpc/commproc.h +++ b/include/asm-powerpc/commproc.h @@ -686,7 +686,4 @@ typedef struct risc_timer_pram { #define CICR_IEN ((uint)0x00000080) /* Int. enable */ #define CICR_SPS ((uint)0x00000001) /* SCC Spread */ -extern void cpm_install_handler(int vec, void (*handler)(void *), void *dev_id); -extern void cpm_free_handler(int vec); - #endif /* __CPM_8XX__ */ -- 1.5.0.6 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] [POWERPC] sysdev/commproc.c: fix copy-n-paste problem 2007-09-18 12:07 [PATCH] [POWERPC][RFC] mpc8xx: fix build with CONFIG_MODULES=y Anton Vorontsov 2007-09-18 12:29 ` [PATCH] [POWERPC][RFC] sysdev/commproc.c: fix build caused by undefined symbols Anton Vorontsov @ 2007-09-18 12:29 ` Anton Vorontsov 1 sibling, 0 replies; 5+ messages in thread From: Anton Vorontsov @ 2007-09-18 12:29 UTC (permalink / raw) To: linuxppc-dev Second export should be for cpm_dpram_phys not cpm_dpram_addr. Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> --- arch/powerpc/sysdev/commproc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/sysdev/commproc.c b/arch/powerpc/sysdev/commproc.c index b562afc..160a8b4 100644 --- a/arch/powerpc/sysdev/commproc.c +++ b/arch/powerpc/sysdev/commproc.c @@ -387,4 +387,4 @@ uint cpm_dpram_phys(u8* addr) { return (dpram_pbase + (uint)(addr - dpram_vbase)); } -EXPORT_SYMBOL(cpm_dpram_addr); +EXPORT_SYMBOL(cpm_dpram_phys); -- 1.5.0.6 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-09-19 11:31 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-09-18 12:07 [PATCH] [POWERPC][RFC] mpc8xx: fix build with CONFIG_MODULES=y Anton Vorontsov 2007-09-18 12:29 ` [PATCH] [POWERPC][RFC] sysdev/commproc.c: fix build caused by undefined symbols Anton Vorontsov 2007-09-18 14:26 ` Kumar Gala 2007-09-19 11:33 ` [PATCH] [POWERPC] Fix various build errors seen on MPC885ADS with CONFIG_MODULES=y Anton Vorontsov 2007-09-18 12:29 ` [PATCH] [POWERPC] sysdev/commproc.c: fix copy-n-paste problem Anton Vorontsov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).