From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev@ozlabs.org, Josh Boyer <jwboyer@gmail.com>,
Stefan Roese <sr@denx.de>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: Sequoia kernel crash workaround.
Date: Wed, 19 Sep 2007 15:08:18 -0500 [thread overview]
Message-ID: <20070919150818.3fecc1bc@weaponx.rchland.ibm.com> (raw)
In-Reply-To: <20070919193024.GA28163@lixom.net>
On Wed, 19 Sep 2007 14:30:24 -0500
Olof Johansson <olof@lixom.net> wrote:
> On Wed, Sep 19, 2007 at 09:19:47PM +0200, Stefan Roese wrote:
> > Hi Valentine,
> >
> > On Wednesday 19 September 2007, Valentine Barshak wrote:
> > > Disabling write pipelining really helps.
> > > Josh, David, what is the right place to put this workaround to?
> > >
> > > Is it OK to do mtdcr(PLB4A0_ACR, mfdcr(PLB4A0_ACR) & ~PLB4_WRP); in
> > > arch/powerpc/boot/cuboot-sequoia.c:sequoia_fixups()?
> > > or
> > > should this be done in
> > > arch/powerpc/platforms/44x/sequoia.c:sequoia_setup_arch()
> > > with dcr_map, dcr_read/write stuff?
> >
> > I vote for putting it into sequoia.c, since it's very likely to happen that
> > Sequoia will at one point be booted without the bootwrapper. Or perhaps it
> > should go into some common code checking the PVR and disabling it when this
> > 440EPx/GRx is detected, since all those boards are affected.
>
> This is what we have setup_cpu functions in the cpu table for. Please
> put it there instead of in board code.
Yes, agreed.
josh
next prev parent reply other threads:[~2007-09-19 20:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 18:39 Sequoia kernel crash workaround Valentine Barshak
2007-09-19 19:12 ` Josh Boyer
2007-09-19 19:19 ` Stefan Roese
2007-09-19 19:30 ` Olof Johansson
2007-09-19 20:08 ` Josh Boyer [this message]
2007-09-20 16:56 ` Valentine Barshak
2007-09-20 17:25 ` Olof Johansson
2007-09-20 17:29 ` Josh Boyer
2007-09-23 8:21 ` Benjamin Herrenschmidt
2007-09-24 10:35 ` Valentine Barshak
2007-09-24 20:55 ` Benjamin Herrenschmidt
2007-09-24 21:01 ` Josh Boyer
2007-09-20 18:03 ` Olof Johansson
2007-09-20 17:32 ` Milton Miller
2007-09-20 17:55 ` [PATCH] PowerPC: add setup_cpu for 44x for processor-specific init Valentine Barshak
2007-09-20 18:13 ` Josh Boyer
2007-09-20 18:15 ` Valentine Barshak
2007-09-20 18:54 ` Kumar Gala
2007-09-20 18:55 ` Valentine Barshak
2007-09-21 1:34 ` Paul Mackerras
2007-09-20 18:02 ` Sequoia kernel crash workaround Josh Boyer
2007-09-20 18:13 ` Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070919150818.3fecc1bc@weaponx.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=jwboyer@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).