linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: mel@skynet.ie (Mel Gorman)
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	jeff@garzik.org, linuxppc-dev@ozlabs.org
Subject: 2.6.23-rc6-mm1: Build failure on ppc64 drivers/ata/pata_scc.c
Date: Thu, 20 Sep 2007 14:13:15 +0100	[thread overview]
Message-ID: <20070920131315.GE24105@skynet.ie> (raw)
In-Reply-To: <20070918011841.2381bd93.akpm@linux-foundation.org>

PPC64 building allmodconfig fails to compile drivers/ata/pata_scc.c . It
doesn't show up on other arches because this driver is specific to the
architecture.

drivers/ata/pata_scc.c: In function `scc_bmdma_status':
drivers/ata/pata_scc.c:734: error: structure has no member named `active_tag'
drivers/ata/pata_scc.c: In function `scc_pata_prereset':
drivers/ata/pata_scc.c:866: warning: passing arg 1 of `ata_std_prereset' from incompatible pointer type
drivers/ata/pata_scc.c: In function `scc_error_handler':
drivers/ata/pata_scc.c:908: warning: passing arg 2 of `ata_bmdma_drive_eh' from incompatible pointer type
drivers/ata/pata_scc.c:908: warning: passing arg 3 of `ata_bmdma_drive_eh' from incompatible pointer type
drivers/ata/pata_scc.c:908: warning: passing arg 5 of `ata_bmdma_drive_eh' from incompatible pointer type
make[2]: *** [drivers/ata/pata_scc.o] Error 1
make[1]: *** [drivers/ata] Error 2
make: *** [drivers] Error 2

The problem seems to be in git-libata-all.patch but based on similar
changes in this patch, the following patch should be the fix. 

Signed-off-by: Mel Gorman <mel@csn.ul.ie>
--- 
 drivers/ata/pata_scc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.23-rc6-mm1-025_fix_ppc64_kgdb/drivers/ata/pata_scc.c linux-2.6.23-rc6-mm1-030_fix_ppc64_sata/drivers/ata/pata_scc.c
--- linux-2.6.23-rc6-mm1-025_fix_ppc64_kgdb/drivers/ata/pata_scc.c	2007-09-18 11:29:26.000000000 +0100
+++ linux-2.6.23-rc6-mm1-030_fix_ppc64_sata/drivers/ata/pata_scc.c	2007-09-20 11:51:01.000000000 +0100
@@ -731,7 +731,7 @@ static u8 scc_bmdma_status (struct ata_p
 	void __iomem *mmio = ap->ioaddr.bmdma_addr;
 	u8 host_stat = in_be32(mmio + SCC_DMA_STATUS);
 	u32 int_status = in_be32(mmio + SCC_DMA_INTST);
-	struct ata_queued_cmd *qc = ata_qc_from_tag(ap, ap->active_tag);
+	struct ata_queued_cmd *qc = ata_qc_from_tag(ap, ap->link.active_tag);
 	static int retry = 0;
 
 	/* return if IOS_SS is cleared */
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

  parent reply	other threads:[~2007-09-20 13:13 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070918011841.2381bd93.akpm@linux-foundation.org>
     [not found] ` <46EF96CC.1080807@linux.vnet.ibm.com>
2007-09-18  9:34   ` 2.6.23-rc6-mm1 Andy Whitcroft
2007-09-18 10:02     ` 2.6.23-rc6-mm1 Benjamin Herrenschmidt
2007-09-18 12:07       ` 2.6.23-rc6-mm1 Kamalesh Babulal
2007-09-18 16:53         ` 2.6.23-rc6-mm1 Andrew Morton
2007-09-18 19:16         ` 2.6.23-rc6-mm1 Greg KH
2007-09-18 21:35           ` 2.6.23-rc6-mm1 Benjamin Herrenschmidt
2007-09-19  9:28 ` 2.6.23-rc6-mm1 -- powerpc link failure Andy Whitcroft
2007-09-19 16:36   ` Segher Boessenkool
2007-09-19 16:52     ` Andy Whitcroft
2007-09-19 17:44   ` Sam Ravnborg
2007-09-25 13:40     ` Andy Whitcroft
2007-09-19  9:36 ` 2.6.23-rc6-mm1 -- powerpc pSeries_log_error panic in rtas_call/early_enable_eeh Andy Whitcroft
     [not found] ` <20070918174408.GC1804@skynet.ie>
2007-09-19 16:29   ` 2.6.23-rc6-mm1: kgdb support on ppc64 utterly broken Mel Gorman
2007-09-20 13:13 ` Mel Gorman [this message]
2007-09-20 14:09   ` 2.6.23-rc6-mm1: Build failure on ppc64 drivers/ata/pata_scc.c Alan Cox
2007-09-20 15:14     ` Mel Gorman
2007-09-20 15:45     ` Kamalesh Babulal
2007-09-20 15:49       ` Kamalesh Babulal
2007-09-22  2:50     ` Satyam Sharma
2007-09-24 11:01       ` Mel Gorman
2007-09-26  3:39       ` Jeff Garzik
2007-09-20 13:25 ` Build failure on ppc64 drivers/block/ps3disk.c Mel Gorman
2007-09-20 13:32   ` Jens Axboe
2007-09-20 13:37   ` 2.6.23-rc6-mm1: Build failures on ppc64_defconfig Satyam Sharma
2007-09-22  6:50     ` Satyam Sharma
2007-09-22  6:51     ` Satyam Sharma
2007-09-22  6:54     ` Satyam Sharma
2007-09-24 11:12       ` Mel Gorman
2007-09-22  7:25     ` Satyam Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070920131315.GE24105@skynet.ie \
    --to=mel@skynet.ie \
    --cc=akpm@linux-foundation.org \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).