linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Valentine Barshak <vbarshak@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org, miltonm@bga.com, david@gibson.dropbear.id.au
Subject: Re: [PATCH] PowerPC: add setup_cpu for 44x for processor-specific init
Date: Thu, 20 Sep 2007 13:13:36 -0500	[thread overview]
Message-ID: <20070920131336.58df01e7@weaponx.rchland.ibm.com> (raw)
In-Reply-To: <20070920175558.GA3191@ru.mvista.com>

On Thu, 20 Sep 2007 21:55:58 +0400
Valentine Barshak <vbarshak@ru.mvista.com> wrote:

> This adds cpu_setup functionality to PowerPC 44x platform.
> The cpu_setup callback is invoked by head_32 code and 
> the identify_cpu() function at early init and is used to 
> initialize FPU on 440EP(x) processors. The FPU initialization 
> was previously done in head_44x.S. Also a workaround for 
> the incorrect write to DDR SDRAM 440EPx/440GRx errata added.
> Data can be written to wrong address in SDRAM when write 
> pipelining is enabled on plb0. The setup_cpu function
> for these processors disables write pipelining.

Wow, you're fast ;)

I'd like to see this split up a bit so there's not so much in one
patch.  Essentially, introduce cpu_setup_44x.S, move the FPU init to
use it, and then add the PLB workaround.

I still need to look at the code too :)

josh

  reply	other threads:[~2007-09-20 18:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19 18:39 Sequoia kernel crash workaround Valentine Barshak
2007-09-19 19:12 ` Josh Boyer
2007-09-19 19:19 ` Stefan Roese
2007-09-19 19:30   ` Olof Johansson
2007-09-19 20:08     ` Josh Boyer
2007-09-20 16:56       ` Valentine Barshak
2007-09-20 17:25         ` Olof Johansson
2007-09-20 17:29           ` Josh Boyer
2007-09-23  8:21             ` Benjamin Herrenschmidt
2007-09-24 10:35               ` Valentine Barshak
2007-09-24 20:55                 ` Benjamin Herrenschmidt
2007-09-24 21:01                   ` Josh Boyer
2007-09-20 18:03           ` Olof Johansson
2007-09-20 17:32         ` Milton Miller
2007-09-20 17:55           ` [PATCH] PowerPC: add setup_cpu for 44x for processor-specific init Valentine Barshak
2007-09-20 18:13             ` Josh Boyer [this message]
2007-09-20 18:15               ` Valentine Barshak
2007-09-20 18:54             ` Kumar Gala
2007-09-20 18:55               ` Valentine Barshak
2007-09-21  1:34             ` Paul Mackerras
2007-09-20 18:02           ` Sequoia kernel crash workaround Josh Boyer
2007-09-20 18:13             ` Valentine Barshak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070920131336.58df01e7@weaponx.rchland.ibm.com \
    --to=jwboyer@linux.vnet.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=miltonm@bga.com \
    --cc=vbarshak@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).