From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 21 Sep 2007 11:00:55 +1000 From: David Gibson To: Segher Boessenkool Subject: Re: Cleanups for physmap_of.c (v2) Message-ID: <20070921010055.GB4124@localhost.localdomain> References: <20070920012225.GG14404@localhost.localdomain> <93451aaa11582c2db3be55961514cce9@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <93451aaa11582c2db3be55961514cce9@kernel.crashing.org> Cc: David Woodhouse , Vitaly Wool , Paul Mackerras , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Sep 20, 2007 at 07:11:59PM +0200, Segher Boessenkool wrote: > > - (the big one) Despite the name, this driver really has > > nothing to do with drivers/mtd/physmap.c. The fact that the flash > > chips must be physically direct mapped is a constrant, but doesn't > > really say anything about the actual purpose of this driver, which is > > to instantiate MTD devices based on information from the device tree. > > Therefore the physmap name is replaced everywhere within the file with > > "of_flash". > > Do you think this code will handle NAND flash later, too? If not, > maybe "of_norflash" is better? Uh.. maybe? I guess we can either extend it or rename it in the future sometime. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson