From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, Olof Johansson <olof@lixom.net>,
Andrew Morton <akpm@linux-foundation.org>,
hch@lst.de, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH v2] pcmcia: Convert io_req_t to use kio_addr_t
Date: Sat, 22 Sep 2007 11:13:03 +0200 [thread overview]
Message-ID: <20070922091303.GA12525@lst.de> (raw)
In-Reply-To: <20070922062551.GE10625@parisc-linux.org>
On Sat, Sep 22, 2007 at 12:25:51AM -0600, Matthew Wilcox wrote:
> > What about the formatting and field widths ?
> >
> > ulong would probably be a lot saner than kio_addr_t and yet more type
> > obfuscation.
>
> I don't think anyone uses ioports > 32bit. Certainly i386 takes an int
> port as parameter to {in,out}[bwl] (and it really only uses 16-bits).
> parisc uses 24 bits. I don't know what the various ppcs do, but pci
> bars can only be 32-bit for ioports. So my opinion is that ioports
> should be uint, not ulong.
The kernel seems to mostly use int, sometimes uint. I never quite got
why pcmcia had to have it's own strange typedef for them.
next prev parent reply other threads:[~2007-09-22 9:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 14:27 [PATCH] pcmcia: Convert io_req_t to use kio_addr_t Olof Johansson
2007-09-14 10:48 ` Andrew Morton
2007-09-14 16:52 ` Olof Johansson
2007-09-21 22:15 ` [PATCH v2] " Olof Johansson
2007-09-21 22:39 ` Alan Cox
2007-09-22 6:25 ` Matthew Wilcox
2007-09-22 9:13 ` Christoph Hellwig [this message]
2007-10-19 20:17 ` [PATCH v3] pcmcia: Convert io_req_t to use unsigned int Olof Johansson
2007-10-28 13:44 ` Dominik Brodowski
2007-10-28 20:10 ` [PATCH] pcmcia: Remove replace kio_addr_t with unsigned int everywhere Olof Johansson
2007-10-28 20:18 ` [PATCH v2] " Olof Johansson
2007-10-28 23:50 ` Stephen Rothwell
2007-10-29 0:16 ` Olof Johansson
2007-11-04 9:11 ` Komuro
2007-09-22 15:11 ` [PATCH v2] pcmcia: Convert io_req_t to use kio_addr_t Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070922091303.GA12525@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=matthew@wil.cx \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).