From: linas@austin.ibm.com (Linas Vepstas)
To: Michael Chan <mchan@broadcom.com>,
linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>,
linuxppc-dev@ozlabs.org
Cc: Matt Carlson <mcarlson@broadcom.com>
Subject: Re: tg3: PCI error recovery
Date: Thu, 27 Sep 2007 12:56:59 -0500 [thread overview]
Message-ID: <20070927175659.GG7970@austin.ibm.com> (raw)
In-Reply-To: <1190850518.25892.5.camel@dell>
During a private conversation about how to save and restore
device state after a pci error is detected, and the device is reset,
the following came up:
On Wed, Sep 26, 2007 at 04:48:38PM -0700, Michael Chan wrote:
> >
> > > 1b) If so, is it safe to call pci_save_state() in
> > > tg3_io_error_detected(), or are we to assume they've been corrupted?
> >
> > My conservative approach is to assume that anything and everything has
> > been corrupted. (e.g. temporary undervoltage on the bus might scramble
> > multiple registers)
>
> In that case, we should call pci_restore_msi_state() to restore the MSI
> state, but this call is only defined if CONFIG_PM is defined.
There seem to be two choices:
1) enable CONFIG_PM in those arches that care about recovering from PCI
errors. (Yuck)
2) remove the ifdef CONFIG_PM from around pci_restore_msi_state() in
rivers/pci/msi.c
I'd go for choice 2, but I thought I'd ask first ...
--linas
parent reply other threads:[~2007-09-27 17:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1190850518.25892.5.camel@dell>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070927175659.GG7970@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc-dev@ozlabs.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).