linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [patch 0/2] MPC834x USB patches
@ 2007-09-28 14:21 jacmet
  2007-09-28 14:21 ` [patch 1/2] Fix mpc834x USB-MPH configuration jacmet
  2007-09-28 14:21 ` [patch 2/2] mpc8349emitx.dts: Setup USB-DR for peripheral mode jacmet
  0 siblings, 2 replies; 3+ messages in thread
From: jacmet @ 2007-09-28 14:21 UTC (permalink / raw)
  To: galak, leoli, linuxppc-dev

MPC834x USB patches. The first is quite serious and would be nice
to get in 2.6.23.

--
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [patch 1/2] Fix mpc834x USB-MPH configuration.
  2007-09-28 14:21 [patch 0/2] MPC834x USB patches jacmet
@ 2007-09-28 14:21 ` jacmet
  2007-09-28 14:21 ` [patch 2/2] mpc8349emitx.dts: Setup USB-DR for peripheral mode jacmet
  1 sibling, 0 replies; 3+ messages in thread
From: jacmet @ 2007-09-28 14:21 UTC (permalink / raw)
  To: galak, leoli, linuxppc-dev

mpc834x USB-MPH configuration got broken by commit
6f442560021aecf08658e26ed9a37e6928ef0fa1. The selection bits in SICRL
should be cleared rather than set to configure the USB MUXes for the MPH.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 arch/powerpc/platforms/83xx/usb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6.23-rc8/arch/powerpc/platforms/83xx/usb.c
===================================================================
--- linux-2.6.23-rc8.orig/arch/powerpc/platforms/83xx/usb.c
+++ linux-2.6.23-rc8/arch/powerpc/platforms/83xx/usb.c
@@ -76,14 +76,14 @@
 			if (port0_is_dr)
 				printk(KERN_WARNING
 					"834x USB port0 can't be used by both DR and MPH!\n");
-			sicrl |= MPC834X_SICRL_USB0;
+			sicrl &= ~MPC834X_SICRL_USB0;
 		}
 		prop = of_get_property(np, "port1", NULL);
 		if (prop) {
 			if (port1_is_dr)
 				printk(KERN_WARNING
 					"834x USB port1 can't be used by both DR and MPH!\n");
-			sicrl |= MPC834X_SICRL_USB1;
+			sicrl &= ~MPC834X_SICRL_USB1;
 		}
 		of_node_put(np);
 	}

--
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [patch 2/2] mpc8349emitx.dts: Setup USB-DR for peripheral mode.
  2007-09-28 14:21 [patch 0/2] MPC834x USB patches jacmet
  2007-09-28 14:21 ` [patch 1/2] Fix mpc834x USB-MPH configuration jacmet
@ 2007-09-28 14:21 ` jacmet
  1 sibling, 0 replies; 3+ messages in thread
From: jacmet @ 2007-09-28 14:21 UTC (permalink / raw)
  To: galak, leoli, linuxppc-dev

Setup dr_mode for USB-DR to peripheral as the default (host mode) doesn't make
much sense for the mini-AB connector on the ITX board.
    
Peripheral mode is preferable to OTG as the fsl_usb2_udc.c driver doesn't yet
properly support it.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 arch/powerpc/boot/dts/mpc8349emitx.dts |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6.23-rc8/arch/powerpc/boot/dts/mpc8349emitx.dts
===================================================================
--- linux-2.6.23-rc8.orig/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ linux-2.6.23-rc8/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -99,6 +99,7 @@
 			#size-cells = <0>;
 			interrupt-parent = < &ipic >;
 			interrupts = <26 8>;
+			dr_mode = "peripheral";
 			phy_type = "ulpi";
 		};
 

--
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-09-28 14:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-28 14:21 [patch 0/2] MPC834x USB patches jacmet
2007-09-28 14:21 ` [patch 1/2] Fix mpc834x USB-MPH configuration jacmet
2007-09-28 14:21 ` [patch 2/2] mpc8349emitx.dts: Setup USB-DR for peripheral mode jacmet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).