From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kernel.dk (brick.kernel.dk [87.55.233.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "A common name", Issuer "A common name" (not verified)) by ozlabs.org (Postfix) with ESMTP id 5C693DDE03 for ; Mon, 1 Oct 2007 21:57:58 +1000 (EST) Date: Mon, 1 Oct 2007 13:59:54 +0200 From: Jens Axboe To: Grant Likely Subject: Re: [PATCH v2 2/6] Sysace: Use the established platform bus api Message-ID: <20071001115954.GD5303@kernel.dk> References: <20070930225112.2476.49914.stgit@trillian.cg.shawcable.net> <20070930225707.2476.24080.stgit@trillian.cg.shawcable.net> <20070930230557.GA17654@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: Christoph Hellwig , linuxppc-dev@ozlabs.org, paulus@samba.org, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Sep 30 2007, Grant Likely wrote: > On 9/30/07, Christoph Hellwig wrote: > > On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote: > > > + if ((rc = platform_driver_register(&ace_platform_driver)) != 0) > > > + goto err_plat; > > > > rc = platform_driver_register(&ace_platform_driver); > > if (rc) > > goto err_plat; > > > > please. > > Okay, will do. > > > > > > + err_plat: > > > + unregister_blkdev(ace_major, "xsysace"); > > > + err_blk: > > > > labels should be indented zero or one space, but not more. > > scripts/Lindent does this. Originally, I *didn't* have my labels > indented. :-) Does Lindent need to be fixed? Seems so, if it idents labels. Just send a fixup patch for that, I'll add your series to the block tree for 2.6.24. -- Jens Axboe