From: David Gibson <david@gibson.dropbear.id.au>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] SPI: Use fsl_spi instead of mpc83xx_spi
Date: Thu, 4 Oct 2007 11:54:03 +1000 [thread overview]
Message-ID: <20071004015403.GA4620@localhost.localdomain> (raw)
In-Reply-To: <878x6kxk62.fsf@macbook.be.48ers.dk>
On Wed, Oct 03, 2007 at 06:00:37PM +0200, Peter Korsgaard wrote:
> >>>>> "Grant" == Grant Likely <grant.likely@secretlab.ca> writes:
>
> Hi,
>
> >> - compatible = "mpc83xx_spi";
> >> + compatible = "fsl_spi";
>
> Grant> Compatible is a list property; this might be more appropriate:
>
> Grant> compatible = "fsl,mpc8313_spi", "fsl_spi";
>
> Fine by me, I'm just following booting-without-of.txt.
Yeah, some of the older bits of booting-without-of.txt are a bit
crufty. There should certainly be a specific compatible value in the
list as well as the general "fsl_spi" one.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
prev parent reply other threads:[~2007-10-04 1:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 15:44 [PATCH] SPI: Use fsl_spi instead of mpc83xx_spi Peter Korsgaard
2007-10-03 15:52 ` Grant Likely
2007-10-03 16:00 ` Peter Korsgaard
2007-10-04 1:54 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004015403.GA4620@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=jacmet@sunsite.dk \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).