* [PATCH] Don't build arch/powerpc/sysdev/dcr.c for ARCH=ppc kernels
@ 2007-10-04 4:50 Grant Likely
2007-10-04 10:56 ` Josh Boyer
0 siblings, 1 reply; 6+ messages in thread
From: Grant Likely @ 2007-10-04 4:50 UTC (permalink / raw)
To: paulus, linuxppc-dev, benh
From: Grant Likely <grant.likely@secretlab.ca>
dcr.c is an arch/powerpc only thing.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
Ben/Paulus,
As far as I can tell this is correct. Having sysdev/dcr.c in the arch/ppc
build spits out warnings. Grep doesn't show anything in arch/ppc that
is using it.
Cheers,
g.
arch/powerpc/sysdev/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
index 592c17e..7f88d4e 100644
--- a/arch/powerpc/sysdev/Makefile
+++ b/arch/powerpc/sysdev/Makefile
@@ -6,7 +6,6 @@ mpic-msi-obj-$(CONFIG_PCI_MSI) += mpic_msi.o mpic_u3msi.o
obj-$(CONFIG_MPIC) += mpic.o $(mpic-msi-obj-y)
obj-$(CONFIG_PPC_MPC106) += grackle.o
-obj-$(CONFIG_PPC_DCR) += dcr.o
obj-$(CONFIG_PPC_DCR_NATIVE) += dcr-low.o
obj-$(CONFIG_PPC_PMI) += pmi.o
obj-$(CONFIG_U3_DART) += dart_iommu.o
@@ -31,6 +30,7 @@ endif
# Temporary hack until we have migrated to asm-powerpc
ifeq ($(ARCH),powerpc)
+obj-$(CONFIG_PPC_DCR) += dcr.o
obj-$(CONFIG_CPM2) += cpm2_common.o cpm2_pic.o
obj-$(CONFIG_8xx) += mpc8xx_pic.o commproc.o
obj-$(CONFIG_UCODE_PATCH) += micropatch.o
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Don't build arch/powerpc/sysdev/dcr.c for ARCH=ppc kernels
2007-10-04 4:50 [PATCH] Don't build arch/powerpc/sysdev/dcr.c for ARCH=ppc kernels Grant Likely
@ 2007-10-04 10:56 ` Josh Boyer
2007-10-04 11:08 ` Benjamin Herrenschmidt
2007-10-04 14:34 ` Michael Ellerman
0 siblings, 2 replies; 6+ messages in thread
From: Josh Boyer @ 2007-10-04 10:56 UTC (permalink / raw)
To: Grant Likely; +Cc: linuxppc-dev, paulus
On Wed, 2007-10-03 at 22:50 -0600, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> dcr.c is an arch/powerpc only thing.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
>
> Ben/Paulus,
>
> As far as I can tell this is correct. Having sysdev/dcr.c in the arch/ppc
> build spits out warnings. Grep doesn't show anything in arch/ppc that
> is using it.
Sorry, no. The ibm_emac driver uses it, which is arch/ppc. (Yes, the
old one.)
If there are warnings, let's fix those up. Perhaps Michael's recent
patches in that area introduced something.
josh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Don't build arch/powerpc/sysdev/dcr.c for ARCH=ppc kernels
2007-10-04 10:56 ` Josh Boyer
@ 2007-10-04 11:08 ` Benjamin Herrenschmidt
2007-10-04 12:16 ` Josh Boyer
2007-10-04 14:34 ` Michael Ellerman
1 sibling, 1 reply; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2007-10-04 11:08 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, paulus
On Thu, 2007-10-04 at 05:56 -0500, Josh Boyer wrote:
> On Wed, 2007-10-03 at 22:50 -0600, Grant Likely wrote:
> > From: Grant Likely <grant.likely@secretlab.ca>
> >
> > dcr.c is an arch/powerpc only thing.
> >
> > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > ---
> >
> > Ben/Paulus,
> >
> > As far as I can tell this is correct. Having sysdev/dcr.c in the arch/ppc
> > build spits out warnings. Grep doesn't show anything in arch/ppc that
> > is using it.
>
> Sorry, no. The ibm_emac driver uses it, which is arch/ppc. (Yes, the
> old one.)
>
> If there are warnings, let's fix those up. Perhaps Michael's recent
> patches in that area introduced something.
What does it use of dcr.c ? Initially, the 4xx bits where totally
inline, but maybe Michael's patches is changing that ?
Ben.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Don't build arch/powerpc/sysdev/dcr.c for ARCH=ppc kernels
2007-10-04 11:08 ` Benjamin Herrenschmidt
@ 2007-10-04 12:16 ` Josh Boyer
0 siblings, 0 replies; 6+ messages in thread
From: Josh Boyer @ 2007-10-04 12:16 UTC (permalink / raw)
To: benh; +Cc: linuxppc-dev, paulus
On Thu, 04 Oct 2007 21:08:04 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> On Thu, 2007-10-04 at 05:56 -0500, Josh Boyer wrote:
> > On Wed, 2007-10-03 at 22:50 -0600, Grant Likely wrote:
> > > From: Grant Likely <grant.likely@secretlab.ca>
> > >
> > > dcr.c is an arch/powerpc only thing.
> > >
> > > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > > ---
> > >
> > > Ben/Paulus,
> > >
> > > As far as I can tell this is correct. Having sysdev/dcr.c in the arch/ppc
> > > build spits out warnings. Grep doesn't show anything in arch/ppc that
> > > is using it.
> >
> > Sorry, no. The ibm_emac driver uses it, which is arch/ppc. (Yes, the
> > old one.)
> >
> > If there are warnings, let's fix those up. Perhaps Michael's recent
> > patches in that area introduced something.
>
> What does it use of dcr.c ? Initially, the 4xx bits where totally
> inline, but maybe Michael's patches is changing that ?
Gah. Sorry, I was thinking of dcr-low.S, not dcr.c. And poor Michael
has nothing to do with it.
Drink coffee. Then think.
josh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Don't build arch/powerpc/sysdev/dcr.c for ARCH=ppc kernels
2007-10-04 10:56 ` Josh Boyer
2007-10-04 11:08 ` Benjamin Herrenschmidt
@ 2007-10-04 14:34 ` Michael Ellerman
2007-10-04 14:42 ` Josh Boyer
1 sibling, 1 reply; 6+ messages in thread
From: Michael Ellerman @ 2007-10-04 14:34 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, paulus
[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]
On Thu, 2007-10-04 at 05:56 -0500, Josh Boyer wrote:
> On Wed, 2007-10-03 at 22:50 -0600, Grant Likely wrote:
> > From: Grant Likely <grant.likely@secretlab.ca>
> >
> > dcr.c is an arch/powerpc only thing.
> >
> > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > ---
> >
> > Ben/Paulus,
> >
> > As far as I can tell this is correct. Having sysdev/dcr.c in the arch/ppc
> > build spits out warnings. Grep doesn't show anything in arch/ppc that
> > is using it.
>
> Sorry, no. The ibm_emac driver uses it, which is arch/ppc. (Yes, the
> old one.)
>
> If there are warnings, let's fix those up. Perhaps Michael's recent
> patches in that area introduced something.
Hmm, I picked a good time to be away :)
I think it's OK. ibm_emac uses dcr_write() but it should always be using
the native one from dcr-native.h. So I think this patch is good.
Just another reason to get rid of arch/ppc :D
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Don't build arch/powerpc/sysdev/dcr.c for ARCH=ppc kernels
2007-10-04 14:34 ` Michael Ellerman
@ 2007-10-04 14:42 ` Josh Boyer
0 siblings, 0 replies; 6+ messages in thread
From: Josh Boyer @ 2007-10-04 14:42 UTC (permalink / raw)
To: michael; +Cc: linuxppc-dev, paulus
On Fri, 05 Oct 2007 00:34:45 +1000
Michael Ellerman <michael@ellerman.id.au> wrote:
> On Thu, 2007-10-04 at 05:56 -0500, Josh Boyer wrote:
> > On Wed, 2007-10-03 at 22:50 -0600, Grant Likely wrote:
> > > From: Grant Likely <grant.likely@secretlab.ca>
> > >
> > > dcr.c is an arch/powerpc only thing.
> > >
> > > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > > ---
> > >
> > > Ben/Paulus,
> > >
> > > As far as I can tell this is correct. Having sysdev/dcr.c in the arch/ppc
> > > build spits out warnings. Grep doesn't show anything in arch/ppc that
> > > is using it.
> >
> > Sorry, no. The ibm_emac driver uses it, which is arch/ppc. (Yes, the
> > old one.)
> >
> > If there are warnings, let's fix those up. Perhaps Michael's recent
> > patches in that area introduced something.
>
> Hmm, I picked a good time to be away :)
>
> I think it's OK. ibm_emac uses dcr_write() but it should always be using
> the native one from dcr-native.h. So I think this patch is good.
Agreed.
> Just another reason to get rid of arch/ppc :D
Agreed.
josh
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-10-04 14:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-04 4:50 [PATCH] Don't build arch/powerpc/sysdev/dcr.c for ARCH=ppc kernels Grant Likely
2007-10-04 10:56 ` Josh Boyer
2007-10-04 11:08 ` Benjamin Herrenschmidt
2007-10-04 12:16 ` Josh Boyer
2007-10-04 14:34 ` Michael Ellerman
2007-10-04 14:42 ` Josh Boyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).