From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] Don't build arch/powerpc/sysdev/dcr.c for ARCH=ppc kernels
Date: Thu, 4 Oct 2007 09:42:17 -0500 [thread overview]
Message-ID: <20071004094217.523a73a9@weaponx.rchland.ibm.com> (raw)
In-Reply-To: <1191508485.7014.7.camel@concordia>
On Fri, 05 Oct 2007 00:34:45 +1000
Michael Ellerman <michael@ellerman.id.au> wrote:
> On Thu, 2007-10-04 at 05:56 -0500, Josh Boyer wrote:
> > On Wed, 2007-10-03 at 22:50 -0600, Grant Likely wrote:
> > > From: Grant Likely <grant.likely@secretlab.ca>
> > >
> > > dcr.c is an arch/powerpc only thing.
> > >
> > > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > > ---
> > >
> > > Ben/Paulus,
> > >
> > > As far as I can tell this is correct. Having sysdev/dcr.c in the arch/ppc
> > > build spits out warnings. Grep doesn't show anything in arch/ppc that
> > > is using it.
> >
> > Sorry, no. The ibm_emac driver uses it, which is arch/ppc. (Yes, the
> > old one.)
> >
> > If there are warnings, let's fix those up. Perhaps Michael's recent
> > patches in that area introduced something.
>
> Hmm, I picked a good time to be away :)
>
> I think it's OK. ibm_emac uses dcr_write() but it should always be using
> the native one from dcr-native.h. So I think this patch is good.
Agreed.
> Just another reason to get rid of arch/ppc :D
Agreed.
josh
prev parent reply other threads:[~2007-10-04 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 4:50 [PATCH] Don't build arch/powerpc/sysdev/dcr.c for ARCH=ppc kernels Grant Likely
2007-10-04 10:56 ` Josh Boyer
2007-10-04 11:08 ` Benjamin Herrenschmidt
2007-10-04 12:16 ` Josh Boyer
2007-10-04 14:34 ` Michael Ellerman
2007-10-04 14:42 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004094217.523a73a9@weaponx.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).