linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bootwrapper: Enable debug info on boot wrapper
@ 2007-10-04  4:05 Grant Likely
  2007-10-10 19:56 ` Grant Likely
  0 siblings, 1 reply; 4+ messages in thread
From: Grant Likely @ 2007-10-04  4:05 UTC (permalink / raw)
  To: linuxppc-dev, david, paulus

From: Grant Likely <grant.likely@secretlab.ca>

Add '-g' to BOOTCFLAGS if CONFIG_DEBUG_INFO is set.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---

 arch/powerpc/boot/Makefile |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index cf80db3..9dfe79b 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -25,6 +25,10 @@ BOOTCFLAGS    := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
 		 -isystem $(shell $(CROSS32CC) -print-file-name=include)
 BOOTAFLAGS	:= -D__ASSEMBLY__ $(BOOTCFLAGS) -traditional -nostdinc
 
+ifdef CONFIG_DEBUG_INFO
+BOOTCFLAGS	+= -g
+endif
+
 ifeq ($(call cc-option-yn, -fstack-protector),y)
 BOOTCFLAGS	+= -fno-stack-protector
 endif

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bootwrapper: Enable debug info on boot wrapper
  2007-10-04  4:05 [PATCH] Bootwrapper: Enable debug info on boot wrapper Grant Likely
@ 2007-10-10 19:56 ` Grant Likely
  2007-10-10 20:10   ` Scott Wood
  2007-10-11  1:34   ` David Gibson
  0 siblings, 2 replies; 4+ messages in thread
From: Grant Likely @ 2007-10-10 19:56 UTC (permalink / raw)
  To: linuxppc-dev, david, paulus, Scott Wood

Any comments on this one?  Scott?  David?

Cheers,
g.

On 10/3/07, Grant Likely <grant.likely@secretlab.ca> wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> Add '-g' to BOOTCFLAGS if CONFIG_DEBUG_INFO is set.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
>
>  arch/powerpc/boot/Makefile |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
> index cf80db3..9dfe79b 100644
> --- a/arch/powerpc/boot/Makefile
> +++ b/arch/powerpc/boot/Makefile
> @@ -25,6 +25,10 @@ BOOTCFLAGS    := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
>                  -isystem $(shell $(CROSS32CC) -print-file-name=include)
>  BOOTAFLAGS     := -D__ASSEMBLY__ $(BOOTCFLAGS) -traditional -nostdinc
>
> +ifdef CONFIG_DEBUG_INFO
> +BOOTCFLAGS     += -g
> +endif
> +
>  ifeq ($(call cc-option-yn, -fstack-protector),y)
>  BOOTCFLAGS     += -fno-stack-protector
>  endif
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bootwrapper: Enable debug info on boot wrapper
  2007-10-10 19:56 ` Grant Likely
@ 2007-10-10 20:10   ` Scott Wood
  2007-10-11  1:34   ` David Gibson
  1 sibling, 0 replies; 4+ messages in thread
From: Scott Wood @ 2007-10-10 20:10 UTC (permalink / raw)
  To: Grant Likely; +Cc: linuxppc-dev, david

Grant Likely wrote:
> Any comments on this one?  Scott?  David?

It's fine with me.

-Scott

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bootwrapper: Enable debug info on boot wrapper
  2007-10-10 19:56 ` Grant Likely
  2007-10-10 20:10   ` Scott Wood
@ 2007-10-11  1:34   ` David Gibson
  1 sibling, 0 replies; 4+ messages in thread
From: David Gibson @ 2007-10-11  1:34 UTC (permalink / raw)
  To: Grant Likely; +Cc: linuxppc-dev

On Wed, Oct 10, 2007 at 01:56:05PM -0600, Grant Likely wrote:
> Any comments on this one?  Scott?  David?

Seems reasonable AFAICT.

> On 10/3/07, Grant Likely <grant.likely@secretlab.ca> wrote:
> > From: Grant Likely <grant.likely@secretlab.ca>
> >
> > Add '-g' to BOOTCFLAGS if CONFIG_DEBUG_INFO is set.
> >
> > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > ---
> >
> >  arch/powerpc/boot/Makefile |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
> > index cf80db3..9dfe79b 100644
> > --- a/arch/powerpc/boot/Makefile
> > +++ b/arch/powerpc/boot/Makefile
> > @@ -25,6 +25,10 @@ BOOTCFLAGS    := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> >                  -isystem $(shell $(CROSS32CC) -print-file-name=include)
> >  BOOTAFLAGS     := -D__ASSEMBLY__ $(BOOTCFLAGS) -traditional -nostdinc
> >
> > +ifdef CONFIG_DEBUG_INFO
> > +BOOTCFLAGS     += -g
> > +endif
> > +
> >  ifeq ($(call cc-option-yn, -fstack-protector),y)
> >  BOOTCFLAGS     += -fno-stack-protector
> >  endif
> >
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@ozlabs.org
> > https://ozlabs.org/mailman/listinfo/linuxppc-dev
> >
> 
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-10-11  1:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-04  4:05 [PATCH] Bootwrapper: Enable debug info on boot wrapper Grant Likely
2007-10-10 19:56 ` Grant Likely
2007-10-10 20:10   ` Scott Wood
2007-10-11  1:34   ` David Gibson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).