LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Milton Miller <miltonm@bga.com>
Cc: Olof Johansson <olof@lixom.net>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] powerpc: don't enable cpu hotplug on mpic-based pseries
Date: Thu, 11 Oct 2007 16:42:51 -0500 (CDT)	[thread overview]
Message-ID: <200710112142.l9BLgp6U031283@sullivan.realtime.net> (raw)
In-Reply-To: <18189.47620.466515.645055@cargo.ozlabs.ibm.com>

Paul Mackerras writes:
> Olof Johansson writes:
>> Don't allow cpu hotplug on systems lacking XICS interrupt controller,
>> since current code is hardcoded for it.
> ...
>> +	for (np = NULL; (np = of_find_node_by_name(np,
>> +						   "interrupt-controller"));) {
> 
> Looks like for_each_node_by_name would be nicer here.
> 
> If you agree, I'll hand-edit your patch to do that and apply it.  Of
> course, ultimately we should implement the necessary mpic bits to
> support cpu hotplug.
> 

While you are editing, can you please change the condition to finding
ppc-xicp instead of not finding open-pic?

thanks.
milton

      parent reply	other threads:[~2007-10-11 21:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071008180406.052382073@mini.kroah.org>
     [not found] ` <20071008180633.GJ7627@kroah.com>
     [not found]   ` <20071009151702.GA19209@lixom.net>
     [not found]     ` <20071009222003.GA21228@kroah.com>
     [not found]       ` <alpine.LFD.0.9999.0710100120340.7766@localhost.localdomain>
     [not found]         ` <alpine.LFD.0.999.0710091625520.3838@woody.linux-foundation.org>
2007-10-10  0:03           ` [stable] [patch 09/12] Fix SMP poweroff hangs Olof Johansson
2007-10-10  0:08           ` [PATCH] powerpc: don't enable cpu hotplug on mpic-based pseries Olof Johansson
2007-10-10  0:18             ` Stephen Rothwell
2007-10-10  0:38               ` [PATCH v2] " Olof Johansson
2007-10-10 10:08                 ` Milton Miller
2007-10-10 16:43                   ` Olof Johansson
2007-10-11 15:25                     ` Milton Miller
2007-10-11  5:52                 ` Paul Mackerras
2007-10-11  5:59                   ` Olof Johansson
2007-10-11 21:42                   ` Milton Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710112142.l9BLgp6U031283@sullivan.realtime.net \
    --to=miltonm@bga.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox