From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Li Yang <leoli@freescale.com>
Cc: linux-ide@vger.kernel.org, Li Yang <leoli@freescale.com>,
jgarzik@pobox.com, Ashish Kalra <ashish.kalra@freescale.com>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] drivers/ata: add support to Freescale 3.0Gbps SATA Controller
Date: Fri, 12 Oct 2007 14:55:22 +0100 [thread overview]
Message-ID: <20071012145522.29dd7413@the-village.bc.nu> (raw)
In-Reply-To: <1192196849-24758-1-git-send-email-leoli@freescale.com>
> + cd = pp->cmdentry + tag;
> +
> + memcpy(fis, &cd->sfis, 6 * 4); /* should we use memcpy_from_io() */
If cd->sfis points at memory over the PCI bus (eg mmio or memory on the
controller card) then you need to use ioread/_io type functions. If
cd->sfis points into host memory where the FIS is delivered by DMA from
the card you will be fine if it was allocated with an _coherent allocator
Alan
next prev parent reply other threads:[~2007-10-12 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 13:47 [PATCH v2] drivers/ata: add support to Freescale 3.0Gbps SATA Controller Li Yang
2007-10-12 13:55 ` Alan Cox [this message]
2007-10-12 14:31 ` Li Yang-r58472
2007-10-12 14:36 ` Kalra Ashish-B00888
2007-10-12 14:21 ` Arnd Bergmann
2007-10-15 11:30 ` Kalra Ashish-B00888
2007-10-15 11:45 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071012145522.29dd7413@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=ashish.kalra@freescale.com \
--cc=jgarzik@pobox.com \
--cc=leoli@freescale.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox