From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e35.co.us.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTP id AB272DDF84 for ; Tue, 16 Oct 2007 04:48:24 +1000 (EST) Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e35.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id l9FImJrU008246 for ; Mon, 15 Oct 2007 14:48:19 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9FImGv1480998 for ; Mon, 15 Oct 2007 12:48:16 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9FImFQI013976 for ; Mon, 15 Oct 2007 12:48:15 -0600 Date: Mon, 15 Oct 2007 13:48:13 -0500 From: Josh Boyer To: Jeff Garzik Subject: Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC. Message-ID: <20071015134813.6aacdcca@weaponx.rchland.ibm.com> In-Reply-To: <4713B10B.5000607@garzik.org> References: <20071015175717.GA4602@ru.mvista.com> <4713B10B.5000607@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 15 Oct 2007 14:27:23 -0400 Jeff Garzik wrote: > Valentine Barshak wrote: > > This patch adds BCM5248 and Marvell 88E1111 PHY support to NEW EMAC driver. > > These PHY chips are used on PowerPC 440EPx boards. > > The PHY code is based on the previous work by Stefan Roese > > > > Signed-off-by: Stefan Roese > > Signed-off-by: Valentine Barshak > > --- > > drivers/net/ibm_newemac/phy.c | 39 +++++++++++++++++++++++++++++++++++++++ > > 1 files changed, 39 insertions(+) > > > > --- linux.orig/drivers/net/ibm_newemac/phy.c 2007-06-15 21:45:18.000000000 +0400 > > +++ linux/drivers/net/ibm_newemac/phy.c 2007-06-15 20:45:15.000000000 +0400 > > @@ -306,8 +306,47 @@ > > .ops = &cis8201_phy_ops > > }; > > > > +static struct mii_phy_def bcm5248_phy_def = { > > + > > + .phy_id = 0x0143bc00, > > + .phy_id_mask = 0x0ffffff0, > > + .name = "BCM5248 10/100 SMII Ethernet", > > + .ops = &generic_phy_ops > > +}; > > + > > +static int m88e1111_init(struct mii_phy *phy) > > +{ > > + printk("%s: Marvell 88E1111 Ethernet\n", __FUNCTION__); > > + phy_write(phy, 0x14, 0x0ce3); > > + phy_write(phy, 0x18, 0x4101); > > + phy_write(phy, 0x09, 0x0e00); > > + phy_write(phy, 0x04, 0x01e1); > > + phy_write(phy, 0x00, 0x9140); > > + phy_write(phy, 0x00, 0x1140); > > + > > + return 0; > > +} > > + > > +static struct mii_phy_ops m88e1111_phy_ops = { > > + .init = m88e1111_init, > > + .setup_aneg = genmii_setup_aneg, > > + .setup_forced = genmii_setup_forced, > > + .poll_link = genmii_poll_link, > > + .read_link = genmii_read_link > > +}; > > + > > +static struct mii_phy_def m88e1111_phy_def = { > > + > > + .phy_id = 0x01410CC0, > > + .phy_id_mask = 0x0ffffff0, > > + .name = "Marvell 88E1111 Ethernet", > > + .ops = &m88e1111_phy_ops, > > +}; > > + > > static struct mii_phy_def *mii_phy_table[] = { > > &cis8201_phy_def, > > + &bcm5248_phy_def, > > + &m88e1111_phy_def, > > &genmii_phy_def, > > Seems sane to me -- ACK -- but we have multiple people sending me > patches for a single driver. That's normal for janitorial cleanups > across the whole tree, but discouraged when multiple people are actively > working on the same driver. > > Please coordinate, and have ONE person send me patches... Who else is sending you patches? Valentine is the only one I've seen send patches recently... josh