* [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node
@ 2007-10-15 15:35 Anton Vorontsov
2007-10-15 15:42 ` Sergei Shtylyov
0 siblings, 1 reply; 12+ messages in thread
From: Anton Vorontsov @ 2007-10-15 15:35 UTC (permalink / raw)
To: linuxppc-dev
This patch creates localbus node, moves bcsr into it, and adds
localbus to the probe path.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
Patch is against galak/powerpc.git master branch.
arch/powerpc/boot/dts/mpc8568mds.dts | 14 +++++++++++---
arch/powerpc/platforms/85xx/mpc85xx_mds.c | 1 +
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/boot/dts/mpc8568mds.dts
index 5439437..296adc3 100644
--- a/arch/powerpc/boot/dts/mpc8568mds.dts
+++ b/arch/powerpc/boot/dts/mpc8568mds.dts
@@ -42,9 +42,17 @@
reg = <00000000 10000000>;
};
- bcsr@f8000000 {
- device_type = "board-control";
- reg = <f8000000 8000>;
+ localbus@f0000000 {
+ compatible = "fsl,mpc8568mds-localbus";
+ #address-cells = <2>;
+ #size-cells = <1>;
+ reg = <f0000000 10000000>;
+ ranges = <0 0 f8000000 0008000>;
+
+ bcsr@0,0 {
+ device_type = "board-control";
+ reg = <0 0 8000>;
+ };
};
soc8568@e0000000 {
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
index 61b3eed..0cf994b 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
@@ -139,6 +139,7 @@ static struct of_device_id mpc85xx_ids[] = {
{ .type = "soc", },
{ .compatible = "soc", },
{ .type = "qe", },
+ { .compatible = "fsl,mpc8568mds-localbus", },
{},
};
--
1.5.0.6
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node
2007-10-15 15:35 [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node Anton Vorontsov
@ 2007-10-15 15:42 ` Sergei Shtylyov
2007-10-15 15:57 ` Anton Vorontsov
0 siblings, 1 reply; 12+ messages in thread
From: Sergei Shtylyov @ 2007-10-15 15:42 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
Anton Vorontsov wrote:
> This patch creates localbus node, moves bcsr into it, and adds
> localbus to the probe path.
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/boot/dts/mpc8568mds.dts
> index 5439437..296adc3 100644
> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
> @@ -42,9 +42,17 @@
> reg = <00000000 10000000>;
> };
>
> - bcsr@f8000000 {
> - device_type = "board-control";
> - reg = <f8000000 8000>;
> + localbus@f0000000 {
> + compatible = "fsl,mpc8568mds-localbus";
Is the entity described as "localbus" indeed so *board* specific?
> + #address-cells = <2>;
> + #size-cells = <1>;
> + reg = <f0000000 10000000>;
> + ranges = <0 0 f8000000 0008000>;
Isn't that range a part of "reg"?
> +
> + bcsr@0,0 {
> + device_type = "board-control";
> + reg = <0 0 8000>;
> + };
> };
>
> soc8568@e0000000 {
WBR, Sergei
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node
2007-10-15 15:42 ` Sergei Shtylyov
@ 2007-10-15 15:57 ` Anton Vorontsov
2007-10-15 16:16 ` [PATCH v2 " Anton Vorontsov
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Anton Vorontsov @ 2007-10-15 15:57 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linuxppc-dev
On Mon, Oct 15, 2007 at 07:42:12PM +0400, Sergei Shtylyov wrote:
> Anton Vorontsov wrote:
>
>> This patch creates localbus node, moves bcsr into it, and adds
>> localbus to the probe path.
>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>
>> diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts
>> b/arch/powerpc/boot/dts/mpc8568mds.dts
>> index 5439437..296adc3 100644
>> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
>> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
>> @@ -42,9 +42,17 @@
>> reg = <00000000 10000000>;
>> };
>> - bcsr@f8000000 {
Heh, this is wrong.
>> - device_type = "board-control";
>> - reg = <f8000000 8000>;
>> + localbus@f0000000 {
>> + compatible = "fsl,mpc8568mds-localbus";
>
> Is the entity described as "localbus" indeed so *board* specific?
That's what booting-without-of.txt gives as an example.
>> + #address-cells = <2>;
>> + #size-cells = <1>;
>> + reg = <f0000000 10000000>;
>> + ranges = <0 0 f8000000 0008000>;
>
> Isn't that range a part of "reg"?
Heh. Right you are.
>> +
>> + bcsr@0,0 {
Hrm, wrong.
>> + device_type = "board-control";
>> + reg = <0 0 8000>;
>> + };
>> };
>> soc8568@e0000000 {
>
> WBR, Sergei
I'll repost fixed version shortly.
Thanks,
--
Anton Vorontsov
email: cbou@mail.ru
backup email: ya-cbou@yandex.ru
irc://irc.freenode.net/bd2
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH v2 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node
2007-10-15 15:57 ` Anton Vorontsov
@ 2007-10-15 16:16 ` Anton Vorontsov
2007-10-15 16:16 ` [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash Anton Vorontsov
2007-10-15 18:47 ` [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node Scott Wood
2 siblings, 0 replies; 12+ messages in thread
From: Anton Vorontsov @ 2007-10-15 16:16 UTC (permalink / raw)
To: linuxppc-dev
This patch creates localbus node, moves bcsr into it, and adds
localbus to the probe path.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
Notice that localbus control registers are in the soc address
space, but ranges are not. Just the same situation as with PCI
nodes.
Patch is against galak/powerpc.git master branch.
arch/powerpc/boot/dts/mpc8568mds.dts | 14 +++++++++++---
arch/powerpc/platforms/85xx/mpc85xx_mds.c | 1 +
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/boot/dts/mpc8568mds.dts
index 5439437..8e15dba 100644
--- a/arch/powerpc/boot/dts/mpc8568mds.dts
+++ b/arch/powerpc/boot/dts/mpc8568mds.dts
@@ -42,9 +42,17 @@
reg = <00000000 10000000>;
};
- bcsr@f8000000 {
- device_type = "board-control";
- reg = <f8000000 8000>;
+ localbus@e0005000 {
+ compatible = "fsl,mpc8568mds-localbus";
+ #address-cells = <2>;
+ #size-cells = <1>;
+ reg = <e0005000 d8>;
+ ranges = <1 0 f8000000 0008000>;
+
+ bcsr@1,0 {
+ device_type = "board-control";
+ reg = <1 0 8000>;
+ };
};
soc8568@e0000000 {
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
index 61b3eed..0cf994b 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
@@ -139,6 +139,7 @@ static struct of_device_id mpc85xx_ids[] = {
{ .type = "soc", },
{ .compatible = "soc", },
{ .type = "qe", },
+ { .compatible = "fsl,mpc8568mds-localbus", },
{},
};
--
1.5.0.6
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash
2007-10-15 15:57 ` Anton Vorontsov
2007-10-15 16:16 ` [PATCH v2 " Anton Vorontsov
@ 2007-10-15 16:16 ` Anton Vorontsov
2007-10-15 17:33 ` Sergei Shtylyov
2007-10-15 18:47 ` [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node Scott Wood
2 siblings, 1 reply; 12+ messages in thread
From: Anton Vorontsov @ 2007-10-15 16:16 UTC (permalink / raw)
To: linuxppc-dev
MPC8568E-MDS have 1 32MB Spansion x16 CFI flash chip. Let's use it.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
Patch is against galak/powerpc.git master branch.
arch/powerpc/boot/dts/mpc8568mds.dts | 35 +++++++++++++++++++++++++++++++++-
1 files changed, 34 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/boot/dts/mpc8568mds.dts
index 8e15dba..1198363 100644
--- a/arch/powerpc/boot/dts/mpc8568mds.dts
+++ b/arch/powerpc/boot/dts/mpc8568mds.dts
@@ -47,12 +47,45 @@
#address-cells = <2>;
#size-cells = <1>;
reg = <e0005000 d8>;
- ranges = <1 0 f8000000 0008000>;
+ ranges = <1 0 f8000000 0008000
+ 0 0 fe000000 2000000>;
bcsr@1,0 {
device_type = "board-control";
reg = <1 0 8000>;
};
+
+ flash@0,0 {
+ compatible = "Spansion,S29GL256N11TFIV2O", "cfi-flash";
+ reg = <0 0 2000000>;
+ probe-type = "CFI";
+ bank-width = <2>;
+ device-width = <1>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ hrcw@0 {
+ label = "hrcw";
+ reg = <0 20001>;
+ read-only;
+ };
+
+ kernel@20000 {
+ label = "kernel";
+ reg = <20000 200000>;
+ };
+
+ rootfs@220000 {
+ label = "rootfs";
+ reg = <220000 1d60000>;
+ };
+
+ uboot@1f80000 {
+ label = "u-boot";
+ reg = <1f80000 80000>;
+ read-only;
+ };
+ };
};
soc8568@e0000000 {
--
1.5.0.6
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash
2007-10-15 16:16 ` [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash Anton Vorontsov
@ 2007-10-15 17:33 ` Sergei Shtylyov
2007-10-15 18:00 ` Kumar Gala
2007-10-16 10:55 ` Anton Vorontsov
0 siblings, 2 replies; 12+ messages in thread
From: Sergei Shtylyov @ 2007-10-15 17:33 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
Anton Vorontsov wrote:
> MPC8568E-MDS have 1 32MB Spansion x16 CFI flash chip. Let's use it.
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/boot/dts/mpc8568mds.dts
> index 8e15dba..1198363 100644
> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
> @@ -47,12 +47,45 @@
> #address-cells = <2>;
> #size-cells = <1>;
> reg = <e0005000 d8>;
> - ranges = <1 0 f8000000 0008000>;
> + ranges = <1 0 f8000000 0008000
> + 0 0 fe000000 2000000>;
>
> bcsr@1,0 {
> device_type = "board-control";
> reg = <1 0 8000>;
> };
> +
> + flash@0,0 {
> + compatible = "Spansion,S29GL256N11TFIV2O", "cfi-flash";
> + reg = <0 0 2000000>;
> + probe-type = "CFI";
I don't get it -- has physmap_of.c rewrite been already committed?
If yes, you don't need probe_type; if no, your "compatible" won't work...
Well, I see that the driver rewrite has been committed (when I wasn't looking
8-)...
> + bank-width = <2>;
> + device-width = <1>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + hrcw@0 {
> + label = "hrcw";
> + reg = <0 20001>;
What?! Odd sized partition? Don't try to follow both the old and new
partition device tree specs -- you'll only get yourself into trouble with
this. The size-cell doesn't bear r/o flag in the new paritions spec.
> + read-only;
> + };
> +
> + kernel@20000 {
> + label = "kernel";
> + reg = <20000 200000>;
> + };
> +
> + rootfs@220000 {
> + label = "rootfs";
> + reg = <220000 1d60000>;
> + };
> +
> + uboot@1f80000 {
> + label = "u-boot";
> + reg = <1f80000 80000>;
> + read-only;
Well, this is not even consistent... :-)
> + };
> + };
> };
WBR, Sergei
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash
2007-10-15 17:33 ` Sergei Shtylyov
@ 2007-10-15 18:00 ` Kumar Gala
2007-10-16 1:12 ` David Gibson
2007-10-16 10:55 ` Anton Vorontsov
1 sibling, 1 reply; 12+ messages in thread
From: Kumar Gala @ 2007-10-15 18:00 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linuxppc-dev
On Oct 15, 2007, at 12:33 PM, Sergei Shtylyov wrote:
> Anton Vorontsov wrote:
>
>> MPC8568E-MDS have 1 32MB Spansion x16 CFI flash chip. Let's use it.
>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>
>> diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/
>> boot/dts/mpc8568mds.dts
>> index 8e15dba..1198363 100644
>> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
>> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
>> @@ -47,12 +47,45 @@
>> #address-cells = <2>;
>> #size-cells = <1>;
>> reg = <e0005000 d8>;
>> - ranges = <1 0 f8000000 0008000>;
>> + ranges = <1 0 f8000000 0008000
>> + 0 0 fe000000 2000000>;
>>
>> bcsr@1,0 {
>> device_type = "board-control";
>> reg = <1 0 8000>;
>> };
>> +
>> + flash@0,0 {
>> + compatible = "Spansion,S29GL256N11TFIV2O", "cfi-flash";
>> + reg = <0 0 2000000>;
>> + probe-type = "CFI";
>
> I don't get it -- has physmap_of.c rewrite been already committed?
> If yes, you don't need probe_type; if no, your "compatible" won't
> work...
> Well, I see that the driver rewrite has been committed (when I
> wasn't looking
> 8-)...
Any NOR flash nodes should conform to the "new" bindings from David
Gibson, et al. Not sure about the status of those being in
physmap_of.c w/regards to 2.6.24.
- k
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash
2007-10-15 18:00 ` Kumar Gala
@ 2007-10-16 1:12 ` David Gibson
0 siblings, 0 replies; 12+ messages in thread
From: David Gibson @ 2007-10-16 1:12 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
On Mon, Oct 15, 2007 at 01:00:24PM -0500, Kumar Gala wrote:
>
> On Oct 15, 2007, at 12:33 PM, Sergei Shtylyov wrote:
>
> > Anton Vorontsov wrote:
> >
> >> MPC8568E-MDS have 1 32MB Spansion x16 CFI flash chip. Let's use it.
> >
> >> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> >
> >> diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/
> >> boot/dts/mpc8568mds.dts
> >> index 8e15dba..1198363 100644
> >> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
> >> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
> >> @@ -47,12 +47,45 @@
> >> #address-cells = <2>;
> >> #size-cells = <1>;
> >> reg = <e0005000 d8>;
> >> - ranges = <1 0 f8000000 0008000>;
> >> + ranges = <1 0 f8000000 0008000
> >> + 0 0 fe000000 2000000>;
> >>
> >> bcsr@1,0 {
> >> device_type = "board-control";
> >> reg = <1 0 8000>;
> >> };
> >> +
> >> + flash@0,0 {
> >> + compatible = "Spansion,S29GL256N11TFIV2O", "cfi-flash";
> >> + reg = <0 0 2000000>;
> >> + probe-type = "CFI";
> >
> > I don't get it -- has physmap_of.c rewrite been already committed?
> > If yes, you don't need probe_type; if no, your "compatible" won't
> > work...
> > Well, I see that the driver rewrite has been committed (when I
> > wasn't looking
> > 8-)...
>
> Any NOR flash nodes should conform to the "new" bindings from David
> Gibson, et al. Not sure about the status of those being in
> physmap_of.c w/regards to 2.6.24.
Yes, in which case probe_type should be dropped, as should the low bit
in the read-only partitions.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash
2007-10-15 17:33 ` Sergei Shtylyov
2007-10-15 18:00 ` Kumar Gala
@ 2007-10-16 10:55 ` Anton Vorontsov
1 sibling, 0 replies; 12+ messages in thread
From: Anton Vorontsov @ 2007-10-16 10:55 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linuxppc-dev
On Mon, Oct 15, 2007 at 09:33:40PM +0400, Sergei Shtylyov wrote:
> Anton Vorontsov wrote:
>
>> MPC8568E-MDS have 1 32MB Spansion x16 CFI flash chip. Let's use it.
>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>
>> diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts
>> b/arch/powerpc/boot/dts/mpc8568mds.dts
>> index 8e15dba..1198363 100644
>> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
>> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
>> @@ -47,12 +47,45 @@
>> #address-cells = <2>;
>> #size-cells = <1>;
>> reg = <e0005000 d8>;
>> - ranges = <1 0 f8000000 0008000>;
>> + ranges = <1 0 f8000000 0008000
>> + 0 0 fe000000 2000000>;
>> bcsr@1,0 {
>> device_type = "board-control";
>> reg = <1 0 8000>;
>> };
>> +
>> + flash@0,0 {
>> + compatible = "Spansion,S29GL256N11TFIV2O", "cfi-flash";
>> + reg = <0 0 2000000>;
>> + probe-type = "CFI";
>
> I don't get it -- has physmap_of.c rewrite been already committed?
> If yes, you don't need probe_type; if no, your "compatible" won't work...
I see.
/* Helper function to handle probing of the obsolete "direct-mapped"
* compatible binding, which has an extra "probe-type" property [...]
Obsolete, very good.
> Well, I see that the driver rewrite has been committed (when I wasn't
> looking 8-)...
>> + bank-width = <2>;
>> + device-width = <1>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + hrcw@0 {
>> + label = "hrcw";
>> + reg = <0 20001>;
>
> What?! Odd sized partition? Don't try to follow both the old and new
> partition device tree specs -- you'll only get yourself into trouble with
> this. The size-cell doesn't bear r/o flag in the new paritions spec.
Thanks for spotting this. It's, of course, forward-porting "thinko".
>> + read-only;
>> + };
>> +
>> + kernel@20000 {
>> + label = "kernel";
>> + reg = <20000 200000>;
>> + };
>> +
>> + rootfs@220000 {
>> + label = "rootfs";
>> + reg = <220000 1d60000>;
>> + };
>> +
>> + uboot@1f80000 {
>> + label = "u-boot";
>> + reg = <1f80000 80000>;
>> + read-only;
>
> Well, this is not even consistent... :-)
Yup, it was a thinko in the hrcw node, not something I really
meant to spread over all ro nodes.
>> + };
>> + };
>> };
>
> WBR, Sergei
Much thanks for the review,
--
Anton Vorontsov
email: cbou@mail.ru
backup email: ya-cbou@yandex.ru
irc://irc.freenode.net/bd2
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node
2007-10-15 15:57 ` Anton Vorontsov
2007-10-15 16:16 ` [PATCH v2 " Anton Vorontsov
2007-10-15 16:16 ` [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash Anton Vorontsov
@ 2007-10-15 18:47 ` Scott Wood
2007-10-15 19:08 ` Kumar Gala
2 siblings, 1 reply; 12+ messages in thread
From: Scott Wood @ 2007-10-15 18:47 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
On Mon, Oct 15, 2007 at 07:57:30PM +0400, Anton Vorontsov wrote:
> On Mon, Oct 15, 2007 at 07:42:12PM +0400, Sergei Shtylyov wrote:
> > Is the entity described as "localbus" indeed so *board* specific?
>
> That's what booting-without-of.txt gives as an example.
The board should have been left out of that. Your compatible should be
something like "fsl,mpc8568-localbus", possibly with some canonical mpc85xx
chip as well, chosen to represent 85xx localbus in general.
-Scott
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node
2007-10-15 18:47 ` [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node Scott Wood
@ 2007-10-15 19:08 ` Kumar Gala
2007-10-15 19:10 ` Scott Wood
0 siblings, 1 reply; 12+ messages in thread
From: Kumar Gala @ 2007-10-15 19:08 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev
On Oct 15, 2007, at 1:47 PM, Scott Wood wrote:
> On Mon, Oct 15, 2007 at 07:57:30PM +0400, Anton Vorontsov wrote:
>> On Mon, Oct 15, 2007 at 07:42:12PM +0400, Sergei Shtylyov wrote:
>>> Is the entity described as "localbus" indeed so *board* specific?
>>
>> That's what booting-without-of.txt gives as an example.
>
> The board should have been left out of that. Your compatible
> should be
> something like "fsl,mpc8568-localbus", possibly with some canonical
> mpc85xx
> chip as well, chosen to represent 85xx localbus in general.
Lets be careful, there are at least two forms of localbus on 85xx.
- k
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node
2007-10-15 19:08 ` Kumar Gala
@ 2007-10-15 19:10 ` Scott Wood
0 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2007-10-15 19:10 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
Kumar Gala wrote:
>
> On Oct 15, 2007, at 1:47 PM, Scott Wood wrote:
>
>> On Mon, Oct 15, 2007 at 07:57:30PM +0400, Anton Vorontsov wrote:
>>> On Mon, Oct 15, 2007 at 07:42:12PM +0400, Sergei Shtylyov wrote:
>>>> Is the entity described as "localbus" indeed so *board* specific?
>>>
>>> That's what booting-without-of.txt gives as an example.
>>
>> The board should have been left out of that. Your compatible should be
>> something like "fsl,mpc8568-localbus", possibly with some canonical
>> mpc85xx
>> chip as well, chosen to represent 85xx localbus in general.
>
> Lets be careful, there are at least two forms of localbus on 85xx.
Do you mean LAWBAR v. BRn/ORn (the manuals refer to the latter as
"localbus", so I'd be inclined to stick with that name, and call the
former mpc8568-lawbar or something), or some 85xx being different than
others?
-Scott
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2007-10-16 10:55 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-15 15:35 [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node Anton Vorontsov
2007-10-15 15:42 ` Sergei Shtylyov
2007-10-15 15:57 ` Anton Vorontsov
2007-10-15 16:16 ` [PATCH v2 " Anton Vorontsov
2007-10-15 16:16 ` [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash Anton Vorontsov
2007-10-15 17:33 ` Sergei Shtylyov
2007-10-15 18:00 ` Kumar Gala
2007-10-16 1:12 ` David Gibson
2007-10-16 10:55 ` Anton Vorontsov
2007-10-15 18:47 ` [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node Scott Wood
2007-10-15 19:08 ` Kumar Gala
2007-10-15 19:10 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).