linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: michael@ellerman.id.au
Cc: sparclinux@vger.kernel.org, sfr@canb.auug.org.au,
	paulus@samba.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c
Date: Wed, 17 Oct 2007 04:23:45 -0700 (PDT)	[thread overview]
Message-ID: <20071017.042345.108116673.davem@davemloft.net> (raw)
In-Reply-To: <20071017.042229.95059231.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Wed, 17 Oct 2007 04:22:29 -0700 (PDT)

> From: Michael Ellerman <michael@ellerman.id.au>
> Date: Wed, 17 Oct 2007 17:12:27 +1000 (EST)
> 
> > Use of_get_pci_dev_node() in axon_msi.c. Switch to including <linux/of.h>
> > so we get the prototype.
> > 
> > Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> 
> I find it ironic that you add of_get_pci_dev_node() as a function
> which gets the node and grabs a reference to it, and then the very
> first usage you make of it doesn't drop the reference at all.

Ignore this poor attempt at humor, I misread your patch :)

  reply	other threads:[~2007-10-17 11:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-17  7:12 [PATCH 1/2] Introduce of_get_pci_dev_node() Michael Ellerman
2007-10-17  7:12 ` [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c Michael Ellerman
2007-10-17 11:22   ` David Miller
2007-10-17 11:23     ` David Miller [this message]
2007-10-18  1:23       ` Michael Ellerman
2007-10-17 11:36     ` Benjamin Herrenschmidt
2007-10-18  1:30       ` Michael Ellerman
2007-10-17 23:04   ` Linas Vepstas
2007-10-18  1:27     ` Michael Ellerman
2007-10-18 19:09       ` Linas Vepstas
2007-10-23  7:36         ` Michael Ellerman
2007-10-23  7:40           ` Benjamin Herrenschmidt
2007-10-18  5:22     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071017.042345.108116673.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=sfr@canb.auug.org.au \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).