From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sunset.davemloft.net (unknown [74.93.104.97]) by ozlabs.org (Postfix) with ESMTP id CE3A3DDE38 for ; Wed, 17 Oct 2007 21:23:31 +1000 (EST) Date: Wed, 17 Oct 2007 04:23:45 -0700 (PDT) Message-Id: <20071017.042345.108116673.davem@davemloft.net> To: michael@ellerman.id.au Subject: Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c From: David Miller In-Reply-To: <20071017.042229.95059231.davem@davemloft.net> References: <8f76815cbbaf5fbab82c843d87bc0dafab038c80.1192605144.git.michael@ellerman.id.au> <20071017.042229.95059231.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Cc: sparclinux@vger.kernel.org, sfr@canb.auug.org.au, paulus@samba.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: David Miller Date: Wed, 17 Oct 2007 04:22:29 -0700 (PDT) > From: Michael Ellerman > Date: Wed, 17 Oct 2007 17:12:27 +1000 (EST) > > > Use of_get_pci_dev_node() in axon_msi.c. Switch to including > > so we get the prototype. > > > > Signed-off-by: Michael Ellerman > > I find it ironic that you add of_get_pci_dev_node() as a function > which gets the node and grabs a reference to it, and then the very > first usage you make of it doesn't drop the reference at all. Ignore this poor attempt at humor, I misread your patch :)