From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
tglx@linutronix.de, netdev@vger.kernel.org,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
mingo@elte.hu
Subject: Re: [NET]: Fix possible dev_deactivate race condition
Date: Thu, 18 Oct 2007 22:38:20 -0700 (PDT) [thread overview]
Message-ID: <20071018.223820.49264165.davem@davemloft.net> (raw)
In-Reply-To: <20071019053624.GA10560@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 19 Oct 2007 13:36:24 +0800
> [NET]: Fix possible dev_deactivate race condition
>
> The function dev_deactivate is supposed to only return when
> all outstanding transmissions have completed. Unfortunately
> it is possible for store operations in the driver's transmit
> function to only become visible after dev_deactivate returns.
>
> This patch fixes this by taking the queue lock after we see
> the end of the queue run. This ensures that all effects of
> any previous transmit calls are visible.
>
> If however we detect that there is another queue run occuring,
> then we'll warn about it because this should never happen as
> we have pointed dev->qdisc to noop_qdisc within the same queue
> lock earlier in the functino.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks Herbert!
next prev parent reply other threads:[~2007-10-19 5:38 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 1:25 [PATCH] synchronize_irq needs a barrier Benjamin Herrenschmidt
2007-10-18 1:45 ` Andrew Morton
2007-10-18 1:55 ` Benjamin Herrenschmidt
2007-10-18 2:12 ` Linus Torvalds
2007-10-18 2:40 ` Benjamin Herrenschmidt
2007-10-18 2:57 ` Benjamin Herrenschmidt
2007-10-18 14:56 ` Herbert Xu
2007-10-18 22:05 ` Benjamin Herrenschmidt
2007-10-18 22:52 ` Linus Torvalds
2007-10-18 23:17 ` Benjamin Herrenschmidt
2007-10-18 23:39 ` Linus Torvalds
2007-10-18 23:52 ` Benjamin Herrenschmidt
2007-10-19 2:32 ` Herbert Xu
2007-10-19 2:52 ` Nick Piggin
2007-10-19 3:28 ` Herbert Xu
2007-10-19 4:49 ` Nick Piggin
2007-10-19 2:55 ` Linus Torvalds
2007-10-19 3:26 ` Linus Torvalds
2007-10-19 4:11 ` Benjamin Herrenschmidt
2007-10-19 4:26 ` Benjamin Herrenschmidt
2007-10-19 5:53 ` Herbert Xu
2007-10-19 4:20 ` Herbert Xu
2007-10-19 4:29 ` Benjamin Herrenschmidt
2007-10-19 4:35 ` Benjamin Herrenschmidt
2007-10-19 4:48 ` Herbert Xu
2007-10-19 4:58 ` Benjamin Herrenschmidt
2007-10-21 21:10 ` Benjamin Herrenschmidt
2007-10-23 3:26 ` [IRQ]: Fix synchronize_irq races with IRQ handler Herbert Xu
2007-10-19 5:36 ` [NET]: Fix possible dev_deactivate race condition Herbert Xu
2007-10-19 5:38 ` David Miller [this message]
2007-10-19 7:35 ` Peter Zijlstra
2007-10-19 9:29 ` Herbert Xu
2007-10-18 14:35 ` [PATCH] synchronize_irq needs a barrier Herbert Xu
2007-10-18 21:35 ` Benjamin Herrenschmidt
2007-10-20 2:02 ` Maxim Levitsky
2007-10-20 2:25 ` Linus Torvalds
2007-10-20 3:10 ` Maxim Levitsky
2007-10-20 4:06 ` Benjamin Herrenschmidt
2007-10-20 4:04 ` Benjamin Herrenschmidt
2007-10-20 4:09 ` Benjamin Herrenschmidt
2007-10-20 3:37 ` Herbert Xu
2007-10-20 3:56 ` Benjamin Herrenschmidt
2007-10-20 4:24 ` Maxim Levitsky
2007-10-20 5:04 ` Benjamin Herrenschmidt
2007-10-20 5:36 ` Maxim Levitsky
2007-10-20 5:46 ` Benjamin Herrenschmidt
2007-10-20 6:06 ` Maxim Levitsky
2007-10-20 6:13 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071018.223820.49264165.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).