linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Marian Balakowicz <m8@semihalf.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 04/15] [POWERPC] CM5200 DTS
Date: Thu, 18 Oct 2007 10:22:56 +1000	[thread overview]
Message-ID: <20071018002256.GA24236@localhost.localdomain> (raw)
In-Reply-To: <4715FE6C.2070201@semihalf.com>

On Wed, Oct 17, 2007 at 02:22:04PM +0200, Marian Balakowicz wrote:
> David Gibson wrote:
> > [snip]
> >> +		flash@c000000 {
> >> +			device_type = "rom";
> >> +			compatible = "direct-mapped";
> >> +			reg = <0c000000 02000000>;
> >> +			probe-type = "CFI";
> >> +			bank-width = <2>;
> >> +			partitions = <00000000 00060000
> >> +				00060000 00020000
> >> +				00080000 00020000
> >> +				000a0000 00020000
> >> +				000c0000 00200000
> >> +				002c0000 01b40000
> >> +				01e00000 00200000>;
> >> +			partition-names = "uboot\0env\0redund_env\0dtb\0kernel\0rootfs\0config";
> >> +		};
> > 
> > First, this is the old flash binding, please use the new one.
> 
> Ok.
> 
> > Second, is the flash really part of the SoC?
> 
> Not directly, it is attached to LocalPlus Bus Controller, which is
> part of the SoC. And the soc@ is currently the only recognized of bus
> for mpc5200, so if we want to move it to some other place new bindings
> will need to be defined for lpc (LocalPlus Controller) bus. But I am
> not quite sure where this should be attached. Bus is under LPC which
> is a part of the SoC, but on the other hand Soc address range covers
> only device control registers not the address space LPC may handle
> (that may be varied). Any ideas?

The bus bridge has to be there.  Is this something similar to the
"localbus" / "chipselect" bus controllers that a whole bunch of the
Freescale SoCs have?  Because the bridged addresses don't lie in the
IMMR, althoug the control registers do, the current convention is to
make the localbus node a sibling of /soc, even though it is really
part of the SoC (/soc would perhaps be better called /immr, but /soc
is established now).  This approach is imperfect, but so are most of
the other compromises we could make.

Incidentally LPC is a pretty bad abbreviation, since LPC more
frequently refers to the Low Pin Count connections that frequently
appear on south bridges or superIO chips.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  parent reply	other threads:[~2007-10-18  0:22 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-06 10:12 [PATCH 00/15] [POWERPC] TQM5200, CM5200 and Motion-PRO support Marian Balakowicz
2007-10-07 11:15 ` [PATCH 01/15] [POWERPC] TQM5200 DTS Marian Balakowicz
2007-10-07 17:36   ` Grant Likely
2007-10-07 20:30     ` Wolfgang Denk
2007-10-17 11:10     ` Marian Balakowicz
2007-10-17 14:57       ` Grant Likely
2007-10-08  6:27   ` Grant Likely
2007-10-08 13:52     ` Kumar Gala
2007-10-07 11:18 ` [PATCH 02/15] [POWERPC] TQM5200 defconfig Marian Balakowicz
2007-10-07 11:19 ` [POWERPC 03/15] [POWERPC] TQM5200 board support Marian Balakowicz
2007-10-07 12:21   ` Stephen Rothwell
2007-10-08  6:21   ` Grant Likely
2007-10-08  7:44     ` Wolfgang Denk
2007-10-08  7:54       ` Grant Likely
2007-10-08 20:48         ` Grant Likely
2007-10-08 22:32           ` Wolfgang Denk
2007-10-08 22:37             ` Grant Likely
2007-10-17 11:24     ` Marian Balakowicz
2007-10-08 15:04   ` Scott Wood
2007-10-17 11:42     ` Marian Balakowicz
2007-10-17 15:33       ` Scott Wood
2007-10-07 11:20 ` [PATCH 04/15] [POWERPC] CM5200 DTS Marian Balakowicz
2007-10-08  1:50   ` David Gibson
2007-10-17 12:22     ` Marian Balakowicz
2007-10-17 14:59       ` Grant Likely
2007-10-18  0:22       ` David Gibson [this message]
2007-10-19 11:06         ` Marian Balakowicz
2007-10-07 11:22 ` [PATCH 05/15] [POWERPC] CM5200 defconfig Marian Balakowicz
2007-10-07 11:24 ` [PATCH 06/15] [POWERPC] CM5200 board support Marian Balakowicz
2007-10-07 12:29   ` Stephen Rothwell
2007-10-08  6:28     ` Grant Likely
2007-10-07 11:25 ` [PATCH 07/15] [POWERPC] Promess Motion-PRO DTS Marian Balakowicz
2007-10-08  1:53   ` David Gibson
2007-10-08  6:44   ` Grant Likely
2007-10-08 14:58   ` Scott Wood
2007-10-08 15:16     ` Grant Likely
2007-10-18 12:50   ` Wolfgang Grandegger
2007-10-18 12:54     ` David Gibson
2007-10-18 13:16     ` Grant Likely
2007-10-07 11:26 ` [PATCH 08/15] [POWERPC] Promess Motion-PRO defconfig Marian Balakowicz
2007-10-07 11:28 ` [PATCH 09/15] [POWERPC] Promess Motion-PRO board support Marian Balakowicz
2007-10-07 12:32   ` Stephen Rothwell
2007-10-08  6:45     ` Grant Likely
2007-10-07 11:30 ` [PATCH 10/15] [POWERPC] Add mpc52xx_find_and_map_path(), refactor utility functions Marian Balakowicz
2007-10-08  6:47   ` Grant Likely
2007-10-07 11:31 ` [PATCH 11/15] [POWERPC] Motion-PRO: Add LED support Marian Balakowicz
2007-10-08  7:10   ` Grant Likely
2007-10-07 11:32 ` [PATCH 12/15] [POWERPC] Add mpc52xx_restart(), mpc52xx_halt(), mpc52xx_power_off() Marian Balakowicz
2007-10-08  7:15   ` Grant Likely
2007-10-08 13:56   ` Kumar Gala
2007-10-07 11:32 ` [PATCH 13/15] [POWERPC] Init restart/halt/power_off machine hooks for TQM5200 Marian Balakowicz
2007-10-07 11:35 ` [PATCH 14/15] [POWERPC] Init restart/halt/power_off machine hooks for CM5200 Marian Balakowicz
2007-10-07 11:36 ` [PATCH 15/15] [POWERPC] Init restart/halt/power_off machine hooks for Motion-PRO Marian Balakowicz
2007-10-08  7:16 ` [PATCH 00/15] [POWERPC] TQM5200, CM5200 and Motion-PRO support Grant Likely
2007-10-08 13:57 ` Kumar Gala
2007-10-09  9:08 ` Marian Balakowicz
2007-10-09 14:38   ` Grant Likely
2007-10-09 15:57     ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071018002256.GA24236@localhost.localdomain \
    --to=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=m8@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).