From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pasmtpB.tele.dk (pasmtpb.tele.dk [80.160.77.98]) by ozlabs.org (Postfix) with ESMTP id EBDFFDE036 for ; Fri, 19 Oct 2007 05:58:31 +1000 (EST) Date: Thu, 18 Oct 2007 21:59:26 +0200 From: Sam Ravnborg To: Milton Miller , David Gibson Subject: Re: Merge dtc Message-ID: <20071018195926.GA22887@uranus.ravnborg.org> References: <9a3f3582990ad94feb76770e82c50bdd@bga.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <9a3f3582990ad94feb76770e82c50bdd@bga.com> Cc: ppcdev , Paul Mackerras , David Gibson List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Oct 18, 2007 at 12:49:54PM -0500, Milton Miller wrote: > On Tue Oct 16 15:02:17 EST 2007, David Gibson wrote: > > >This very large patch incorporates a copy of dtc into the kernel > >source, in arch/powerpc/boot/dtc-src. This means that dtc is no > >longer an external dependency to build kernels with configurations > >which need a dtb file. > > > >Signed-off-by: David Gibson > > > >Too big for the list, full patch at > >http://ozlabs.org/~dgibson/home/merge-dtc.patch+ > > So split it up. The obvious one is "here is the unique content, then > copy these files from dtc git" would have been better. One obvious split is a patch solely containing the _shipped files. And next patch the rest. As Milton already pointed out you should build dtc in the dtc directory (why the -src prefix??). And the dtc specific Makefile looks like something from the late 80'. Please drop all these ALLUPPERCASE variables and accept a little bit of redundancy. Then mere humans may be able to read the Makefile. When you have done the above I would be happy to review the kbuild bits. Sam