From: David Gibson <david@gibson.dropbear.id.au>
To: Li Yang <leoli@freescale.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH v5 9/9] add MPC837x MDS board default device tree
Date: Fri, 19 Oct 2007 10:56:13 +1000 [thread overview]
Message-ID: <20071019005613.GA18240@localhost.localdomain> (raw)
In-Reply-To: <1192702580-6353-1-git-send-email-leoli@freescale.com>
On Thu, Oct 18, 2007 at 06:16:20PM +0800, Li Yang wrote:
> Signed-off-by: Li Yang <leoli@freescale.com>
> ---
> diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts b/arch/powerpc/boot/dts/mpc8377_mds.dts
> new file mode 100644
> index 0000000..8530de6
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/mpc8377_mds.dts
> @@ -0,0 +1,282 @@
[snip]
> + crypto@30000 {
> + model = "SEC3";
> + compatible = "talitos";
That compatible doesn't look specific enough. It should at least have
a vendor portion. In general it's best to have all the information
you need to pick a driver and options in compatible, rather than
splitting that info into model.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-10-19 0:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 10:16 [PATCH v5 9/9] add MPC837x MDS board default device tree Li Yang
2007-10-18 13:17 ` Kumar Gala
2007-10-18 13:33 ` Li Yang-r58472
2007-10-18 14:04 ` Kumar Gala
2007-10-19 0:56 ` David Gibson [this message]
2007-10-19 7:31 ` Li Yang-r58472
2007-10-19 13:10 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071019005613.GA18240@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).