From: David Gibson <david@gibson.dropbear.id.au>
To: Jon Loeliger <jdl@jdl.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 3/4] DTC: Appease the printf() format $Gods with a correct type.
Date: Sat, 20 Oct 2007 17:19:20 +1000 [thread overview]
Message-ID: <20071020071920.GF26642@localhost.localdomain> (raw)
In-Reply-To: <E1IivsP-00078Q-Hf@jdl.com>
On Fri, Oct 19, 2007 at 12:43:13PM -0500, Jon Loeliger wrote:
>
> Signed-off-by: Jon Loeliger <jdl@freescale.com>
Hrm.... I'm very dubious about this.
What compiler/platform is this? I can't off the top of my head think
of one where size_t shouldn't be promoted to int automatically.
Or there's the %z modifier, which explicitly specifies a size_t, but
I'm not sure if that's C99 or a glibc extension.
> ---
> tests/get_name.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tests/get_name.c b/tests/get_name.c
> index 2481741..a76bdf8 100644
> --- a/tests/get_name.c
> +++ b/tests/get_name.c
> @@ -55,7 +55,7 @@ void check_name(void *fdt, const char *path)
>
> if (len != strlen(getname))
> FAIL("fdt_get_name(%s) returned length %d instead of %d",
> - path, len, strlen(getname));
> + path, len, (int) strlen(getname));
>
> /* Now check that it doesn't break if we omit len */
> getname2 = fdt_get_name(fdt, offset, NULL);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-10-20 7:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 17:43 [PATCH 3/4] DTC: Appease the printf() format $Gods with a correct type Jon Loeliger
2007-10-20 7:19 ` David Gibson [this message]
2007-10-20 8:51 ` Andreas Schwab
2007-10-20 9:06 ` David Gibson
2007-10-22 16:50 ` Jon Loeliger
2007-10-22 16:55 ` Josh Boyer
2007-10-23 0:26 ` David Gibson
2007-10-23 1:03 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071020071920.GF26642@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox