From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: linuxppc-dev@ozlabs.org, Johannes Berg <johannes@sipsolutions.net>
Subject: Re: ioctl32 unknown cmds with 2.6.24-rc1
Date: Thu, 25 Oct 2007 17:19:52 +0200 [thread overview]
Message-ID: <200710251719.53285.arnd@arndb.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0710251649520.3812@pademelon.sonytel.be>
On Thursday 25 October 2007, Geert Uytterhoeven wrote:
> In many cases these ioctls can indeed not be handled.
> E.g. when using `hdparm -tT /dev/ps3da', hdparm issues an ioctl to flush the
> cache. But this ioctl is not supported, not before and not after 2.6.23.
> Before 2.6.23, it didn't print the message, in 2.6.23, it does.
What I would expect to happen here is:
compat_blkdev_ioctl gets into the BLKFLSBUF case and calls blkdev_ioctl,
which calls blkdev_driver_ioctl, which returns -ENOTTY because
ps3disk_fops does not contain an unlocked_ioctl() or ioctl() method.
compat_sys_ioctl then detects that BLKFLSBUF was already handled by
compat_blkdev_ioctl (it did not return -ENOIOCTLCMD) and propagates
the error code to user space, without printing the message.
Whatever is different from that description must be what goes wrong.
Arnd <><
prev parent reply other threads:[~2007-10-25 15:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 12:30 ioctl32 unknown cmds with 2.6.24-rc1 Johannes Berg
2007-10-24 14:27 ` Arnd Bergmann
2007-10-25 13:38 ` Johannes Berg
2007-10-25 13:45 ` Geert Uytterhoeven
2007-10-25 14:20 ` Arnd Bergmann
2007-10-25 14:51 ` Geert Uytterhoeven
2007-10-25 15:19 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710251719.53285.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).