From: Arnd Bergmann <arnd@arndb.de>
To: akpm@linux-foundation.org, linuxppc-dev@ozlabs.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Johannes Berg <johannes@sipsolutions.net>,
Jens Axboe <jens.axboe@oracle.com>
Cc: linux-kernel@vger.kernel.org, Philip Langdale <philipl@overt.org>
Subject: [PATCH] compat_ioctl: fix block device compat ioctl regression
Date: Sat, 27 Oct 2007 11:38:05 +0200 [thread overview]
Message-ID: <200710271138.06456.arnd@arndb.de> (raw)
In-Reply-To: <47228A9E.80505@overt.org>
From: Philip Langdale <philipl@overt.org>
The conversion of handlers to compat_blkdev_ioctl accidentally
disabled handling of most ioctl numbers on block devices because
of a typo. Fix the one line to enable it all again.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Mea Culpa. This should have been found by my testing, as it's clear
that most of my big patch never worked at all. Sorry for causing
problems for everyone involved here.
I'm attributing the patch to Philip, as he's the one who pointed
out to me what the fix is.
Arnd <><
--- a/block/compat_ioctl.c
+++ b/block/compat_ioctl.c
@@ -581,7 +581,7 @@ static int compat_blkdev_driver_ioctl(struct inode *inode, struct file *file,
{
int ret;
- switch (arg) {
+ switch (cmd) {
case HDIO_GET_UNMASKINTR:
case HDIO_GET_MULTCOUNT:
case HDIO_GET_KEEPSETTINGS:
next parent reply other threads:[~2007-10-27 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47221F91.60401@overt.org>
[not found] ` <200710270051.38748.arnd@arndb.de>
[not found] ` <47228A9E.80505@overt.org>
2007-10-27 9:38 ` Arnd Bergmann [this message]
2007-10-27 11:34 ` [PATCH] compat_ioctl: fix block device compat ioctl regression Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710271138.06456.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=jens.axboe@oracle.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=philipl@overt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).