From: Stefan Roese <sr@denx.de>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: Add 405EX support to new EMAC driver
Date: Thu, 1 Nov 2007 22:31:11 +0100 [thread overview]
Message-ID: <200711012231.11385.sr@denx.de> (raw)
In-Reply-To: <20071101160709.7e7c0181@weaponx.rchland.ibm.com>
On Thursday 01 November 2007, Josh Boyer wrote:
> > > - if (dev->type != RGMII_AXON)
> > > - return;
> > > -
> > > mutex_lock(&dev->lock);
> >
> > That will break 440GX boards that need to use the RGMII for data and the
> > ZMII for MDIO.
> >
> > You may want to change the name RGMII_AXON something like RGMII_HAS_MDIO
> > instead and set that for 405EX as well instead.
>
> And perhaps adding a comment about that since the meaning of that code
> isn't very obvious. That way people that aren't the original author
> of the driver don't get confused again.
Will do. I'll send a fixed version tomorrow.
Best regards,
Stefan
next prev parent reply other threads:[~2007-11-01 21:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 14:54 [PATCH] net: Add 405EX support to new EMAC driver Stefan Roese
2007-11-01 20:37 ` Benjamin Herrenschmidt
2007-11-01 21:07 ` Josh Boyer
2007-11-01 21:31 ` Stefan Roese [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-11-02 7:14 Stefan Roese
2007-11-02 16:03 ` Olof Johansson
2007-11-04 3:37 ` Benjamin Herrenschmidt
2007-11-04 17:16 ` Olof Johansson
2007-11-05 9:19 ` Stefan Roese
2007-11-05 11:04 ` Benjamin Herrenschmidt
2007-11-05 11:11 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711012231.11385.sr@denx.de \
--to=sr@denx.de \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).