From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, JOFT@gmx.de
Subject: Re: [PATCH] Register AC97 Controller Reference with the platform bus
Date: Thu, 8 Nov 2007 07:20:54 -0600 [thread overview]
Message-ID: <20071108072054.57a1f95c@zod.rchland.ibm.com> (raw)
In-Reply-To: <20071107161142.7901.51817.stgit@trillian.cg.shawcable.net>
On Wed, 07 Nov 2007 09:14:15 -0700
Grant Likely <grant.likely@secretlab.ca> wrote:
> From: Joachim Foerster <mls.JOFT@gmx.de>
>
> Add AC97 platform bus registration for Xilinx Virtex platforms.
>
> Signed-off-by: Joachim Foerster <JOFT@gmx.de>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
>
> Josh, can you please pick up this patch into your .24 queue. I know it's
> arch/ppc, but it is harmless and it is required to get the AC97 device
> driver working on Virtex boards. It's pretty much a bug fix in that regard.
Will do shortly. I have a couple other bug fix patches I need to get
out as well.
josh
>
> Cheers,
> g.
>
> arch/ppc/syslib/virtex_devices.c | 31 +++++++++++++++++++++++++++++++
> 1 files changed, 31 insertions(+), 0 deletions(-)
>
> diff --git a/arch/ppc/syslib/virtex_devices.c b/arch/ppc/syslib/virtex_devices.c
> index 96188f8..95ee313 100644
> --- a/arch/ppc/syslib/virtex_devices.c
> +++ b/arch/ppc/syslib/virtex_devices.c
> @@ -169,6 +169,29 @@
> }, \
> }
>
> +#define XPAR_AC97_CONTROLLER_REFERENCE(num) { \
> + .name = "ml403_ac97cr", \
> + .id = num, \
> + .num_resources = 3, \
> + .resource = (struct resource[]) { \
> + { \
> + .start = XPAR_OPB_AC97_CONTROLLER_REF_##num##_BASEADDR, \
> + .end = XPAR_OPB_AC97_CONTROLLER_REF_##num##_HIGHADDR, \
> + .flags = IORESOURCE_MEM, \
> + }, \
> + { \
> + .start = XPAR_OPB_INTC_0_OPB_AC97_CONTROLLER_REF_##num##_PLAYBACK_INTERRUPT_INTR, \
> + .end = XPAR_OPB_INTC_0_OPB_AC97_CONTROLLER_REF_##num##_PLAYBACK_INTERRUPT_INTR, \
> + .flags = IORESOURCE_IRQ, \
> + }, \
> + { \
> + .start = XPAR_OPB_INTC_0_OPB_AC97_CONTROLLER_REF_##num##_RECORD_INTERRUPT_INTR, \
> + .end = XPAR_OPB_INTC_0_OPB_AC97_CONTROLLER_REF_##num##_RECORD_INTERRUPT_INTR, \
> + .flags = IORESOURCE_IRQ, \
> + }, \
> + }, \
> +}
> +
> /* UART 8250 driver platform data table */
> struct plat_serial8250_port virtex_serial_platform_data[] = {
> #if defined(XPAR_UARTNS550_0_BASEADDR)
> @@ -303,6 +326,14 @@ struct platform_device virtex_platform_devices[] = {
> #if defined(XPAR_TFT_3_BASEADDR)
> XPAR_TFT(3),
> #endif
> +
> + /* AC97 Controller Reference instances */
> +#if defined(XPAR_OPB_AC97_CONTROLLER_REF_0_BASEADDR)
> + XPAR_AC97_CONTROLLER_REFERENCE(0),
> +#endif
> +#if defined(XPAR_OPB_AC97_CONTROLLER_REF_1_BASEADDR)
> + XPAR_AC97_CONTROLLER_REFERENCE(1),
> +#endif
> };
>
> /* Early serial support functions */
>
prev parent reply other threads:[~2007-11-08 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 16:14 [PATCH] Register AC97 Controller Reference with the platform bus Grant Likely
2007-11-08 13:20 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071108072054.57a1f95c@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=JOFT@gmx.de \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).