From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de01egw01.freescale.net (de01egw01.freescale.net [192.88.165.102]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "de01egw01.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id E31A2DDE9D for ; Fri, 9 Nov 2007 05:15:20 +1100 (EST) Date: Thu, 8 Nov 2007 12:15:08 -0600 From: Kim Phillips To: avorontsov@ru.mvista.com Subject: Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing) Message-Id: <20071108121508.39a65c33.kim.phillips@freescale.com> In-Reply-To: <20071108141611.GA5770@localhost.localdomain> References: <20071105121530.5c38fbb7.kim.phillips@freescale.com> <20071108141611.GA5770@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org, paulus@samba.org, Li Yang , jgarzik@pobox.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 8 Nov 2007 17:16:11 +0300 Anton Vorontsov wrote: > On Mon, Nov 05, 2007 at 12:15:30PM -0600, Kim Phillips wrote: > > Hello all, > > > > the following patches fix RGMII timing for rev. 2.1 of the mpc8360, > > according to erratum #2 (erratum text included below). Basically the > > most intrusive part is the addition of two new RGMII Internal Delay > > modes; one for TX delay only, and the other for RX delay only (i.e, not > > both at the same time). > > > > Please review, and since this affects both netdev and powerpc trees, > > one maintainer should ack them for the other to push upstream (i.e, > > Kumar acks them, and Leo picks them up to go through netdev or the > > other way around; either way is fine with me). I'm hoping they're > > trivial enough to go in 2.6.24. > > > > Depending on how the review goes, a follow-on patch to u-boot will be > > sent out that fixes up the phy-connection-type in the device tree (from > > "rgmii-id" to "rgmii-rxid" iff on mpc8360rev2.1). > > I've upgraded CPU to rev2.1, board rev0.3. > thanks for testing this. I tested these patches on a "pilot assy 0.3". > Applied 5/5 patches onto paulus/powerpc.git at e403149c92a. Here is > the results: > > If I use -rxid, then geth not able to transmit anything. > With -txid geth not able to receive anything. > > With just -id everything works fine though... > > > Maybe there should be another condition, in addition to cpu rev2.1? > the errata simply states 'pilot boards', but we can probably modify u-boot to look at the cpu rev and the board rev (BCSR 12). My bcsr12 looks like: => md.b f800000c 1 f800000c: 10 . what is yours? If it's something like 0x03, the u-boot patch will probably look like: if ((bcsr[12] == 0x10) && (immr->sysconf.spridr == SPR_8360_REV21 || immr->sysconf.spridr == SPR_8360E_REV21)) /* if phy-connection-type is "rgmii-id", set it to "rgmii-rxid" */ ... but these linux patches would remain the same (the clk and data delay settings for the UCC's are still valid; it's just the PHY config that is triggering your problem from what I can tell). Thanks, Kim > > mpc8360 rev 2.1 erratum #2: > > ----------- > > Recommended AC timings for chip 8360Rev2.1 UCC ETH RGMII when working > > with Rev Pilot MDS for proper RGMII operation: > > > > IMMR_BASE + 0x14A8[4:5] = 11 (clk delay for UCC 2) > > IMMR_BASE + 0x14A8[18:19] = 11 (clk delay for UCC 1) > > IMMR_BASE + 0x14AC[20:27] = 10101010 (data delay for both UCC's) > > > > The Phy (Marvell 88e1111) should be configured NOT to work with RGMII > > delay for TxD.